]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
common: CephContext::_refresh_perf_values() checks for null _mempool_perf 62754/head
authorCasey Bodley <cbodley@redhat.com>
Wed, 9 Apr 2025 19:26:51 +0000 (15:26 -0400)
committerCasey Bodley <cbodley@redhat.com>
Wed, 9 Apr 2025 19:26:53 +0000 (15:26 -0400)
commit76b3f0118cad36aa522802b181b03cdc0cdd3942
tree5a529657d9843964abcee46cb400f90dcd733943
parentdfb213454be7a8d24dee673de18854949d804e05
common: CephContext::_refresh_perf_values() checks for null _mempool_perf

test_perf_counters_cache.cc initializes the CephContext with flag
CINIT_FLAG_NO_CCT_PERF_COUNTERS which leaves both _cct_perf and
_mempool_perf as nullptrs

the CephContextServiceThread calls _refresh_perf_values() regularly,
which guards _cct_perf->set() calls with a nullptr check, but the
_mempool_perf->set() calls were unguarded

this led to occasional unittest_perf_counters_cache segfaults in make
check

Fixes: https://tracker.ceph.com/issues/64895
Signed-off-by: Casey Bodley <cbodley@redhat.com>
src/common/ceph_context.cc