]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
crimson/osd: fix stuck recovery 62812/head
authorMatan Breizman <mbreizma@redhat.com>
Tue, 15 Apr 2025 07:35:31 +0000 (07:35 +0000)
committerMatan Breizman <mbreizma@redhat.com>
Tue, 15 Apr 2025 09:42:41 +0000 (09:42 +0000)
commit8451cd2b4c8bdd861c4edb56e580723db769ba60
tree1767bd3cbdaaa084414516ab0a2f34b4854fd212
parent583d50ab36a9143bfc1ef6152a0b716088717be7
crimson/osd: fix stuck recovery

https://github.com/ceph/ceph/pull/62080 tested version was **different**
from the one that got merged.
The untested change was changing the boolean returned from start_recovery_ops.
While the seastar::repeat loop in BackgroundRecoveryT<T>::start() was changed accordingly,
other do_recovery() return cases were not considered.

See Tested / Merged here: https://github.com/Matan-B/ceph/pull/2/files

start_recovery_ops used by do_recovery should return whether the iteration (i.e recovery) keep going.

_Note: This has caused a regression in our suite_

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
src/crimson/osd/osd_operations/background_recovery.cc
src/crimson/osd/pg_recovery.cc