]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mgr/rbd_support: always parse interval and start_time in Schedules::remove() 62965/head
authorIlya Dryomov <idryomov@gmail.com>
Tue, 25 Mar 2025 08:13:27 +0000 (09:13 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Fri, 25 Apr 2025 07:17:59 +0000 (09:17 +0200)
commit6a77bf5755f22a6c94718465f7c524ec5db8297d
tree37d3a2fdacdc6a4c1367e8e880059d50ccefc1f8
parent465bfad768c474d363ab52a56d5e8403565fe712
mgr/rbd_support: always parse interval and start_time in Schedules::remove()

Commit 1b62447071a9 ("mgr/rbd_support: fix schedule remove") addressed
the issue that it was concerned with in a rather suboptimal way: instead
of moving the parsing of interval and start_time upfront to be able to
bail early, it wrapped from_string() constructors with try/finally and
left the conditional behavior in place.

Fixes: https://tracker.ceph.com/issues/70640
Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit bcd676356231c97c8275e6c03becc2c58497f20d)
qa/workunits/rbd/cli_generic.sh
src/pybind/mgr/rbd_support/schedule.py