]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
qa/standalone/misc: make less noise for asok calculation 67096/head
authorKyr Shatskyy <kyrylo.shatskyy@clyso.com>
Tue, 27 Jan 2026 18:17:04 +0000 (19:17 +0100)
committerKefu Chai <k.chai@proxmox.com>
Sat, 4 Apr 2026 05:22:21 +0000 (13:22 +0800)
commit907304b3a26e51abfe6517d071767494c16a239f
tree3b8c51f9492ccae8e42e538489e83cdc673a842c
parentfa54c4911cc9d1b8977778bc311ff7d635889d8f
qa/standalone/misc: make less noise for asok calculation

The $() notation not only calls the function, it also creates subshell,
which is a separate process. Additionally in debug mode all the content
of the function get_asok_path is printed out in the logs each time
whenever it is called, for example:

    ...stderr://home/ubuntu/cephtest/clone.client.0/qa/standalone/ceph-helpers.sh:552: run_mgr:  get_asok_path
    ...stderr://home/ubuntu/cephtest/clone.client.0/qa/standalone/ceph-helpers.sh:107: get_asok_path:  local name=
    ...stderr://home/ubuntu/cephtest/clone.client.0/qa/standalone/ceph-helpers.sh:108: get_asok_path:  '[' -n '' ']'
    ...stderr:///home/ubuntu/cephtest/clone.client.0/qa/standalone/ceph-helpers.sh:111: get_asok_path:  get_asok_dir
    ...stderr:///home/ubuntu/cephtest/clone.client.0/qa/standalone/ceph-helpers.sh:99: get_asok_dir:  '[' -n '' ']'
    ...stderr:///home/ubuntu/cephtest/clone.client.0/qa/standalone/ceph-helpers.sh:102: get_asok_dir:  echo /tmp/ceph-asok.48301
    ...stderr://home/ubuntu/cephtest/clone.client.0/qa/standalone/ceph-helpers.sh:111: get_asok_path:  echo '/tmp/ceph-asok.48301/$cluster-$name.asok'

Instead of calling get_asok_path each time we need to define osd.0,
etc. asok file path, we just predefine corresponding variables.
It not only avoids extra resource usage, but also removes a lot of
noise from the logs.

Signed-off-by: Kyr Shatskyy <kyrylo.shatskyy@clyso.com>
qa/standalone/ceph-helpers.sh
qa/standalone/misc/mclock-config.sh