]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
reef: mds: use SimpleLock::WAIT_ALL for wait mask 67495/head
authorPatrick Donnelly <pdonnell@ibm.com>
Tue, 24 Feb 2026 19:30:24 +0000 (14:30 -0500)
committerPatrick Donnelly <pdonnell@ibm.com>
Wed, 25 Feb 2026 15:37:44 +0000 (10:37 -0500)
commit0199784ab931d02e1a704ab4676bf1a3442dac97
tree030323f78231dfeff2b3c4d3ec5c29a0c192d0da
parent4d32a6dd24e3f11965bb95690b8165ea6f7cc658
reef: mds: use SimpleLock::WAIT_ALL for wait mask

The Locker uses has_any_waiter for a particular lock to evaluate whether
to nudge the log. For the squid, tentacle, and main branches, this
larger bit mask (all 64 bits) will cause this to wrongly return true for
other locks which have waiters. The side-effect of waking requests
spuriously is undesirable but should not affect performance
significantly.

For reef and older releases, using std::numeric_limits<uint64_t>::max()
in has_any_waiter() causes a bitwise overflow that sets the wait-queue
search bound impossibly high, resulting in the method always incorrectly
returning false. This results in nudge_log never nudging the log!

Note: for reef the fix is different because of the interface refactor.
For that reason, this fix is applied directly to reef.

Fixes: db5c9dc2e6cc95a8d112c2131e4cac5340ca9dd0
Fixes: https://tracker.ceph.com/issues/75141
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
src/mds/SimpleLock.h