]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
crimson/osd: make load_obc(obc, md_ref) return void 68200/head
authorKefu Chai <k.chai@proxmox.com>
Fri, 3 Apr 2026 08:05:36 +0000 (16:05 +0800)
committerKefu Chai <k.chai@proxmox.com>
Sun, 5 Apr 2026 12:33:27 +0000 (20:33 +0800)
commit6d9d564d66b4ff413f6adf7e3162215913e70631
tree9d046d46c65f76fea319d77e87ea6342ad28a32b
parentada80f8f07536cc42508a5d545a36ac86cc24af1
crimson/osd: make load_obc(obc, md_ref) return void

load_obc() taking an already-resolved loaded_object_md_t::ref is
synchronous, because it just populates obc state, it does yield.
Returning an errorated future was unnecessary and caused a
-Wunused-result warning at its only call site:
ECRecoveryBackend::maybe_load_obc().

In this change, we change it to return void and deduplicate the OBC
population logic: the private async overload (taking future<md_ref>)
now validates ssc and returns object_corrupted on failure.

This silences the warning, and simpler this way. The async error
propagation is preserved.

Signed-off-by: Kefu Chai <k.chai@proxmox.com>
src/crimson/osd/object_context_loader.cc
src/crimson/osd/object_context_loader.h