]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
osd: PGLog Attach correct version to missing list when ignoring log entries 68718/head
authorAlex Ainscow <aainscow@uk.ibm.com>
Wed, 18 Mar 2026 09:22:26 +0000 (09:22 +0000)
committerAlex Ainscow <aainscow@uk.ibm.com>
Fri, 8 May 2026 16:36:54 +0000 (17:36 +0100)
commit6568b290c126023b88c77c4ab1f563d82116673c
tree7693e213b7853ca1fde502a1e4445dd6eca45e5d
parent6502188013c056d9eefbbd27e1adaabfffa1319f
osd: PGLog Attach correct version to missing list when ignoring log entries

A previous fix for PR 66698 fixed an issue where log entries associated with
partial writes were being processed incorrectly (see that PR and associated
tracker for details).  The fix was to ignore log entries that should not have
been present on the non-primary shard.

The problem with that approach is that in a more complex scenario, where the
log contained a partial write, followed by a full write AND the shard is
backfilling, then the missing list was being given the version prior to the
full write, rather than prior to the clone.

Our fix here corrects how the missing list version is calculated.

See the associated tracker for instructions on how to recreate

Conflicts:
a/src/test/osd/TestECFailoverWithPeering.cc

Unittest not backported because it is based on a new framework in Umbrella

Fixes: https://tracker.ceph.com/issues/75211
Signed-off-by: Alex Ainscow <aainscow@uk.ibm.com>
(cherry picked from commit 7967f28c774f3f3830f10e02e88d6ef3e82b9f82)
src/osd/PGLog.cc
src/osd/PGLog.h