]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr/cephadm: allow nvmeof group assignment for NVMe-oF services 68747/head
authorKushal Deb <Kushal.Deb@ibm.com>
Tue, 5 May 2026 05:30:12 +0000 (11:00 +0530)
committerKushal Deb <Kushal.Deb@ibm.com>
Tue, 5 May 2026 07:36:35 +0000 (13:06 +0530)
commit43bf8f21ecc1c032621e0a25099f7cf7f02f934f
treed29026fad674c4e57d2f8769cabf61e2b26aaec1
parent1df675bb6097e052041825bb0361e1397fb021cf
mgr/cephadm: allow nvmeof group assignment for NVMe-oF services

NVMe-oF services created in older releases may have a service_id that does
not include the gateway group name, because those services could be created
without a group.
The current validation requires an NVMe-oF service_id to end with
the configured group name when spec.group is set. This is correct for new
services, but it blocks the documented upgrade flow for existing legacy
services where the user exports the existing spec, adds spec.group, and
applies it back.

Allow this narrow update path when the service already exists, the stored
spec has no group, and the incoming spec keeps the same service_id while
adding a non-empty group. Keep the existing validation for new services and
for services that already have a group, so duplicate or misleading group
configurations are still rejected.

Signed-off-by: Kushal Deb <Kushal.Deb@ibm.com>
src/pybind/mgr/cephadm/module.py