]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
crimson/cmake: restrict -Wno-non-virtual-dtor to C++ sources 69520/head
authorSun Yuechi <sunyuechi@iscas.ac.cn>
Mon, 15 Jun 2026 20:10:15 +0000 (04:10 +0800)
committerSun Yuechi <sunyuechi@iscas.ac.cn>
Tue, 16 Jun 2026 11:25:22 +0000 (19:25 +0800)
commit82ab9cc2e3609cf0a172b3f322ac4420316c8642
tree929ac4e124b631f7145ee8ed4c0a7b384ac21554
parent2286265c0a847f111529178d9a2405621449ad40
crimson/cmake: restrict -Wno-non-virtual-dtor to C++ sources

The seastar target exports -Wno-non-virtual-dtor as a PUBLIC compile
option, so it leaks to every target that links seastar, including C
sources such as crimson-common's reverse.c, producing:

  cc1: warning: command-line option '-Wno-non-virtual-dtor' is valid for C++/ObjC++ but not for C

Guard the option with $<COMPILE_LANGUAGE:CXX> so that it only applies to
C++ compilations.

Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>
src/CMakeLists.txt