]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
src/crimson/osd: statically link the ISA plugin in crimson-osd 70481/head
authorShraddha Agrawal <shraddha.agrawal000@gmail.com>
Fri, 24 Jul 2026 08:21:36 +0000 (13:51 +0530)
committerShraddha Agrawal <shraddha.agrawal000@gmail.com>
Fri, 24 Jul 2026 08:21:36 +0000 (13:51 +0530)
commit93300b45c05db96485dc4be1084b3121e938225a
treec2ba78ee3acc307dd8007487a6f231cadcd1a9c0
parent1462041bd9fd86bb86e3987c642e4170f11e8711
src/crimson/osd: statically link the ISA plugin in crimson-osd

Problem:
Before this change, when the ISA plugin (classic build, dlopen'd),
would try to log, it'd segfault due to null g_ceph_context.

We need a way to make logging work for EC plugins in crimson.

Solution:

By building the ISA plugin WITH_CRIMSON, its logging is
routed to seastar's logger, solving the issue.

It is not build separately and dlopen'd like in classic because
doing so would require the plugin to have its own seastar logger
copy, an undesirable outcome.

It is a statically built library in the crimson-osd binary, and thus
it shares the single seastar logger. The library is linked with
--whole-archive so the self-registration constructor is not dropped.

Signed-off-by: Shraddha Agrawal <shraddha.agrawal000@gmail.com>
src/crimson/CMakeLists.txt
src/erasure-code/isa/ErasureCodePluginIsa.cc