]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
common: instantiate strict_si_cast<long> not strict_si_cast<int64_t> 9934/head
authorKefu Chai <kchai@redhat.com>
Sat, 25 Jun 2016 17:02:03 +0000 (01:02 +0800)
committerKefu Chai <kchai@redhat.com>
Fri, 8 Jul 2016 13:20:53 +0000 (21:20 +0800)
commit31db4c5f9f725e13e38f3c90744e299e023d02a4
treec71427983c14a8468b41ef43564cc70d5a7b3a51
parent3f60a675245d0647df84ef289e0eb2511aa4d797
common: instantiate strict_si_cast<long> not strict_si_cast<int64_t>

this fixes the build on armf.

on 32bit platforms, cstdint is very likely to

 typedef long long int int64_t;

this results in compilation error like

 `common/strtol.cc:190:75: error: duplicate explicit instantiation of 'T
 strict_si_cast(const char, std::string) [with T = long long int;
 std::string = std::basic_string]'

 [-fpermissive]
 template int64_t strict_si_cast(const char *str, std::string *err);
 ^`

we can address this by instantiate the primitive type of `long long`
instead of `in64_t`.

Fixes: http://tracker.ceph.com/issues/16398
Signed-off-by: Kefu Chai <kchai@redhat.com>
src/common/strtol.cc