]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-volume tests.util verify devices that don't exist don't break get_devices
authorAlfredo Deza <adeza@redhat.com>
Tue, 2 Oct 2018 15:18:22 +0000 (11:18 -0400)
committerAlfredo Deza <adeza@redhat.com>
Tue, 2 Oct 2018 15:18:22 +0000 (11:18 -0400)
Signed-off-by: Alfredo Deza <adeza@redhat.com>
src/ceph-volume/ceph_volume/tests/util/test_disk.py

index 941cb60c3accab33b43c999a37f9fbfc1d5823d3..fd3839307e86a76208a56ff09c77f4075773ebbf 100644 (file)
@@ -197,6 +197,15 @@ class TestGetDevices(object):
             _mapper_path=str(tmpdir))
         assert result == {}
 
+    def test_no_devices_are_found_errors(self, tmpdir):
+        block_path, dev_path, mapper_path = self.setup_paths(tmpdir)
+        os.makedirs(os.path.join(block_path, 'sda'))
+        result = disk.get_devices(
+            _sys_block_path=block_path, # has 1 device
+            _dev_path=str(tmpdir), # exists but no devices
+            _mapper_path='/does/not/exist/path') # does not exist
+        assert result == {}
+
     def test_sda_block_is_found(self, tmpfile, tmpdir):
         block_path, dev_path, mapper_path = self.setup_paths(tmpdir)
         dev_sda_path = os.path.join(dev_path, 'sda')