]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-volume: fix lvm list 33077/head
authorGuillaume Abrioux <gabrioux@redhat.com>
Wed, 5 Feb 2020 01:29:14 +0000 (02:29 +0100)
committerGuillaume Abrioux <gabrioux@redhat.com>
Wed, 5 Feb 2020 07:39:29 +0000 (08:39 +0100)
17957d9beb42a04b8f180ccb7ba07d43179a41d3 introduced a regression in `lvm
list`.

When passing a vg/lv path for generating a single report, it fails
because the filter used in the `lvs` command isn't right. It uses the lv
name instead of the vg name because `os.path.basename(device)` is used
while it should be `os.path.dirname(device)`

Fixes: https://tracker.ceph.com/issues/43969
Signed-off-by: Guillaume Abrioux <gabrioux@redhat.com>
src/ceph-volume/ceph_volume/devices/lvm/listing.py

index f718dd89c9f439dd771ce25cc6b26b4d8d548b4d..f8a7dda78dd50ddcbe5e18e2040bb02a32bd60db 100644 (file)
@@ -169,7 +169,7 @@ class List(object):
                 lv = api.get_first_lv(filters={'vg_name': pv.vg_name})
             # or VG.
             else:
-                vg_name = os.path.basename(device)
+                vg_name = os.path.dirname(device)
                 lv = api.get_first_lv(filters={'vg_name': vg_name})
                 arg_is_vg = True