crimson/.../lba_manager: convert reserve_region to use cursor

Signed-off-by: Samuel Just <sjust@redhat.com>

diff --git a/src/crimson/os/seastore/lba/btree_lba_manager.cc b/src/crimson/os/seastore/lba/btree_lba_manager.cc
index 90959ec258203757d9ac7b9fcbe8623fdeb3d766..b87defb72aebb9b38b8b3efca6fbec8800fc3689 100644 (file)
--- a/src/crimson/os/seastore/lba/btree_lba_manager.cc
+++ b/src/crimson/os/seastore/lba/btree_lba_manager.cc
@@ -240,17 +240,16 @@ BtreeLBAManager::resolve_indirect_cursor(
 BtreeLBAManager::alloc_extent_ret
 BtreeLBAManager::reserve_region(
   Transaction &t,
-  LBAMapping pos,
+  LBACursorRef cursor,
   laddr_t addr,
   extent_len_t len)
 {
   LOG_PREFIX(BtreeLBAManager::reserve_region);
-  DEBUGT("{} {}~{}", t, pos, addr, len);
-  assert(pos.is_viewable());
+  DEBUGT("{} {}~{}", t, *cursor, addr, len);
+  assert(cursor->is_viewable());
   auto c = get_context(t);
   auto btree = co_await get_btree<LBABtree>(cache, c);
-  auto &cursor = pos.get_effective_cursor();
-  auto iter = btree.make_partial_iter(c, cursor);
+  auto iter = btree.make_partial_iter(c, *cursor);
   lba_map_val_t val{
     len,
     P_ADDR_ZERO,

diff --git a/src/crimson/os/seastore/lba/btree_lba_manager.h b/src/crimson/os/seastore/lba/btree_lba_manager.h
index 24456128cd9be171728a9881398c34f64c9ce005..87c59c2a111d0cf841fce78b141fcef26ba749af 100644 (file)
--- a/src/crimson/os/seastore/lba/btree_lba_manager.h
+++ b/src/crimson/os/seastore/lba/btree_lba_manager.h
@@ -77,7 +77,7 @@ public:
 
   alloc_extent_ret reserve_region(
     Transaction &t,
-    LBAMapping pos,
+    LBACursorRef pos,
     laddr_t laddr,
     extent_len_t len) final;
 

diff --git a/src/crimson/os/seastore/lba_manager.h b/src/crimson/os/seastore/lba_manager.h
index 022aec14fbdc6d04f143ff3ea592f0f139c8999e..ba00f37a88cacc9a26fff61802027914e1f8bbf0 100644 (file)
--- a/src/crimson/os/seastore/lba_manager.h
+++ b/src/crimson/os/seastore/lba_manager.h
@@ -125,7 +125,7 @@ public:
    */
   virtual alloc_extent_ret reserve_region(
     Transaction &t,
-    LBAMapping pos,
+    LBACursorRef cursor,
     laddr_t hint,
     extent_len_t len) = 0;
 

diff --git a/src/crimson/os/seastore/transaction_manager.h b/src/crimson/os/seastore/transaction_manager.h
index de368c9324e629ca621ded704cda4edaedfbe5f2..c3a8bbdb6a6508f6ed784fe1cb41ac1f97f2124a 100644 (file)
--- a/src/crimson/os/seastore/transaction_manager.h
+++ b/src/crimson/os/seastore/transaction_manager.h
@@ -538,7 +538,7 @@ public:
     pos = co_await pos.refresh();
     auto pin = co_await lba_manager->reserve_region(
       t,
-      std::move(pos),
+      pos.get_effective_cursor_ref(),
       hint,
       len
     );