cls/cls_rbd: pass string by reference

Signed-off-by: Jeffrey Lu <lzhng2000@aliyun.com>

diff --git a/src/cls/rbd/cls_rbd.cc b/src/cls/rbd/cls_rbd.cc
index 8b88c5eaeda40f80f7d6dc938a05065687f6e1fa..36271dab4443eb8f039079f5ad90410ccd88a2f5 100644 (file)
--- a/src/cls/rbd/cls_rbd.cc
+++ b/src/cls/rbd/cls_rbd.cc
@@ -2983,7 +2983,7 @@ int read_peers(cls_method_context_t hctx,
   return 0;
 }
 
-int read_peer(cls_method_context_t hctx, const std::string uuid,
+int read_peer(cls_method_context_t hctx, const std::string &uuid,
               cls::rbd::MirrorPeer *peer) {
   bufferlist bl;
   int r = cls_cxx_map_get_val(hctx, peer_key(uuid), &bl);
@@ -3003,7 +3003,7 @@ int read_peer(cls_method_context_t hctx, const std::string uuid,
   return 0;
 }
 
-int write_peer(cls_method_context_t hctx, const std::string uuid,
+int write_peer(cls_method_context_t hctx, const std::string &uuid,
                const cls::rbd::MirrorPeer &peer) {
   bufferlist bl;
   ::encode(peer, bl);

diff --git a/src/test/librados/test.cc b/src/test/librados/test.cc
index 469b7145bff875611dd0eda22fb2d2621c278897..5ba5a68f6311a0534011fc75430681eee289f4df 100644 (file)
--- a/src/test/librados/test.cc
+++ b/src/test/librados/test.cc
@@ -104,7 +104,7 @@ int rados_pool_set(
     rados_t *cluster,
     const std::string &pool_name,
     const std::string &var,
-    const std::string val)
+    const std::string &val)
 {
   JSONFormatter cmd_f;
   cmd_f.open_object_section("command");

diff --git a/src/tools/rbd/Utils.cc b/src/tools/rbd/Utils.cc
index 4f4b2e87824fd0a88dd57152bf733a464db86120..13be4147271f11faca2348abc5da088fa084ba51 100644 (file)
--- a/src/tools/rbd/Utils.cc
+++ b/src/tools/rbd/Utils.cc
@@ -591,7 +591,7 @@ int init_and_open_image(const std::string &pool_name,
   return 0;
 }
 
-int snap_set(librbd::Image &image, const std::string snap_name) {
+int snap_set(librbd::Image &image, const std::string &snap_name) {
   int r = image.snap_set(snap_name.c_str());
   if (r < 0) {
     std::cerr << "error setting snapshot context: " << cpp_strerror(r)

diff --git a/src/tools/rbd/Utils.h b/src/tools/rbd/Utils.h
index 0f290df237db1716bcc22fb0576ab02caea30209..7caf43d7f16fab67784aa21d567bb2e370fe8dd5 100644 (file)
--- a/src/tools/rbd/Utils.h
+++ b/src/tools/rbd/Utils.h
@@ -96,7 +96,7 @@ int init_and_open_image(const std::string &pool_name,
                         librados::Rados *rados, librados::IoCtx *io_ctx,
                         librbd::Image *image);
 
-int snap_set(librbd::Image &image, const std::string snap_name);
+int snap_set(librbd::Image &image, const std::string &snap_name);
 
 std::string image_id(librbd::Image& image);
 

diff --git a/src/tools/rbd/action/Kernel.cc b/src/tools/rbd/action/Kernel.cc
index 541da95c8b499760917c5269ce31a84d273c1659..3c552d985eb9b1f61e85e325fc285ffc64248a6c 100644 (file)
--- a/src/tools/rbd/action/Kernel.cc
+++ b/src/tools/rbd/action/Kernel.cc
@@ -62,12 +62,12 @@ static std::string map_option_int_cb(const char *value_char)
   return stringify(d);
 }
 
-static void put_map_option(const std::string key, std::string val)
+static void put_map_option(const std::string &key, std::string val)
 {
   map_options[key] = val;
 }
 
-static int put_map_option_value(const std::string opt, const char *value_char,
+static int put_map_option_value(const std::string &opt, const char *value_char,
                                 std::string (*parse_cb)(const char *))
 {
   if (!value_char || *value_char == '\0') {