]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/onode-staged-tree: allow non-empty DeltaRecorder to be destructed 40462/head
authorYingxin Cheng <yingxin.cheng@intel.com>
Mon, 29 Mar 2021 06:04:13 +0000 (14:04 +0800)
committerYingxin Cheng <yingxin.cheng@intel.com>
Mon, 29 Mar 2021 13:19:36 +0000 (21:19 +0800)
Fixes: http://tracker.ceph.com/issues/50028
Signed-off-by: Yingxin Cheng <yingxin.cheng@intel.com>
src/crimson/os/seastore/onode_manager/staged-fltree/node_delta_recorder.h

index 63aa16c63520f8259a9d66719f06bfe4e8506db7..a37fdb6d509623a1be97ba585bad6e0c0e70538f 100644 (file)
@@ -18,7 +18,10 @@ namespace crimson::os::seastore::onode {
 class DeltaRecorder {
  public:
   virtual ~DeltaRecorder() {
-    assert(is_empty());
+    /* May be non-empty if transaction is abandoned without
+     * being submitted -- conflicts are a particularly common
+     * example (denoted generally by returning crimson::ct_error::eagain).
+     */
   }
 
   bool is_empty() const {