]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
Add annotation to all assembly files to turn off stack-execute bit 2961/head
authorDan Mick <dan.mick@redhat.com>
Sat, 15 Nov 2014 01:59:57 +0000 (17:59 -0800)
committerDan Mick <dan.mick@redhat.com>
Tue, 18 Nov 2014 23:19:32 +0000 (15:19 -0800)
See discussion in http://tracker.ceph.com/issues/10114

Building with these changes allows output from readelf like this:

 $ readelf -lW src/.libs/librados.so.2 | grep GNU_STACK
  GNU_STACK      0x000000 0x0000000000000000 0x0000000000000000 0x000000
0x000000 RW  0x8

(note the absence of 'X' in 'RW')

Fixes: #10114
Signed-off-by: Dan Mick <dan.mick@redhat.com>
(cherry picked from commit 06a245a9845c0c126fb3106b41b2fd2bc4bc4df3)
(not-yet-present-in-firefly files in isa-l manually removed)

src/common/crc32c_intel_fast_asm.S
src/common/crc32c_intel_fast_zero_asm.S

index 4ca5d65032e2902726ee72b5954e4363ae30b9f3..2189684b4c75ed1056a80a222e897a59d6d7d686 100644 (file)
@@ -662,3 +662,5 @@ global %1_slver
 %endmacro
 ;;;       func            core, ver, snum
 slversion crc32_iscsi_00, 00,   02,  0014
+; inform linker that this doesn't require executable stack
+section .note.GNU-stack noalloc noexec nowrite progbits
index b7246f26380d2160b2fc81dfd38054edd532cad5..34b7f4890169fef05b750d956214a9130fd7cc66 100644 (file)
@@ -644,3 +644,5 @@ global %1_slver
 %endmacro
 ;;;       func            core, ver, snum
 slversion crc32_iscsi_zero_00, 00,   02,  0014
+; inform linker that this doesn't require executable stack
+section .note.GNU-stack noalloc noexec nowrite progbits