mon_store_converter.cc: move convert() call out of assert()

The convert() call is changing data. To prevent Heisenbugs
depending in NDEBUG definition (e.g. if debug is off).

Move convert() call out of the assert call and use assert
only on the result value of the call.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

diff --git a/src/tools/mon_store_converter.cc b/src/tools/mon_store_converter.cc
index 7b8add8cd0627e94c09e3ed91ac2b2b189f1ef5d..59b3265dd8555cf80f17a38e987af2751fe98ef6 100644 (file)
--- a/src/tools/mon_store_converter.cc
+++ b/src/tools/mon_store_converter.cc
@@ -325,7 +325,8 @@ int main(int argc, const char *argv[])
   string store(args[0]);
   string new_store(store);
   MonitorStoreConverter converter(store, new_store);
-  assert(!converter.convert());
+  int ret = converter.convert();
+  assert(!ret);
   assert(converter.match());
 
   std::cout << "store successfully converted to new format" << std::endl;