Removed the check for parameter validation in op_get()

Signed-off-by: Babu Shanmugam <anbu@enovance.com>

diff --git a/src/rgw/rgw_common.cc b/src/rgw/rgw_common.cc
index 32e127eedb43fd659fd966e72bdb1bcd570b9fbd..43cab394db9351450d298ebc3d7f187a89906e42 100644 (file)
--- a/src/rgw/rgw_common.cc
+++ b/src/rgw/rgw_common.cc
@@ -447,8 +447,7 @@ int XMLArgs::parse()
     if (ret >= 0) {
       string& name = nv.get_name();
       string& val = nv.get_val();
-      if(name.length() > 0)
-        val_map[name] = val;
+      val_map[name] = val;
 
       if ((name.compare("acl") == 0) ||
           (name.compare("location") == 0) ||

diff --git a/src/rgw/rgw_rest_metadata.cc b/src/rgw/rgw_rest_metadata.cc
index 1ec6a65c940dd301d7c4df0f70900a1ea732c30a..a0a79eb752c4de91b537646d3f52baf068f91cf0 100644 (file)
--- a/src/rgw/rgw_rest_metadata.cc
+++ b/src/rgw/rgw_rest_metadata.cc
@@ -159,10 +159,6 @@ void RGWOp_Metadata_Delete::execute() {
 }
 
 RGWOp *RGWHandler_Metadata::op_get() {
-  if (s->args.get_num_params() > 0 && 
-      !s->args.exists("key")) {
-    return NULL;
-  }
   if (s->args.exists("key"))
     return new RGWOp_Metadata_Get;
   else

diff --git a/src/test/test_rgw_admin_meta.cc b/src/test/test_rgw_admin_meta.cc
index 7cfc53f18e8091e6c639126b53f9cb54f5fb1182..5f811a97bf82ff0c69d28eceb146c3791ea0c6be 100644 (file)
--- a/src/test/test_rgw_admin_meta.cc
+++ b/src/test/test_rgw_admin_meta.cc
@@ -651,9 +651,6 @@ TEST(TestRGWAdmin, meta_get){
 
   ASSERT_EQ(0, user_info(uid, display_name, info));
  
-  /*Check with a wrong parameter*/
-  g_test->send_request(string("GET"), string("/admin/metadata/user?keys=test"));
-  EXPECT_EQ(405U, g_test->get_resp_code());
   g_test->send_request(string("GET"), string("/admin/metadata/user?key=test"));
   EXPECT_EQ(404U, g_test->get_resp_code());