]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
qa: fix TypeError in delay 67476/head
authorJos Collin <jcollin@redhat.com>
Tue, 24 Feb 2026 02:03:13 +0000 (07:33 +0530)
committerJos Collin <jcollin@redhat.com>
Tue, 24 Feb 2026 07:56:55 +0000 (13:26 +0530)
random.randrange() asserts TypeError for arguments of type 'float'.
So use random.uniform() to fix this.

Fixes: https://tracker.ceph.com/issues/75090
Signed-off-by: Jos Collin <jcollin@redhat.com>
qa/tasks/cephfs_mirror_thrash.py
qa/tasks/mds_thrash.py

index b69d41e88bfb43a19d916e226397b3a4f38a7423..1e504375f8393d037f9fc8f598e0af9aa6228f21 100644 (file)
@@ -101,7 +101,7 @@ class CephFSMirrorThrasher(ThrasherGreenlet):
         while not self.is_stopped:
             delay = self.max_thrash_delay
             if self.randomize:
-                delay = random.randrange(self.min_thrash_delay, self.max_thrash_delay)
+                delay = random.uniform(self.min_thrash_delay, self.max_thrash_delay)
 
             if delay > 0.0:
                 self.log('waiting for {delay} secs before thrashing'.format(delay=delay))
@@ -136,7 +136,7 @@ class CephFSMirrorThrasher(ThrasherGreenlet):
                 # wait for a while before restarting
                 delay = self.max_revive_delay
                 if self.randomize:
-                    delay = random.randrange(0.0, self.max_revive_delay)
+                    delay = random.uniform(0.0, self.max_revive_delay)
 
                 self.log('waiting for {delay} secs before reviving daemons'.format(delay=delay))
                 self.sleep_unless_stopped(delay)
index e7b3023caf5820a4d894fba3aff68b39f9e85b34..017b141f04266dd5e4ead668c1316c1fe64d66b5 100644 (file)
@@ -230,7 +230,7 @@ class MDSThrasher(ThrasherGreenlet):
         while not self.is_stopped:
             delay = self.max_thrash_delay
             if self.randomize:
-                delay = random.randrange(0.0, self.max_thrash_delay)
+                delay = random.uniform(0.0, self.max_thrash_delay)
 
             if delay > 0.0:
                 self.log('waiting for {delay} secs before thrashing'.format(delay=delay))
@@ -307,7 +307,7 @@ class MDSThrasher(ThrasherGreenlet):
                 # standby
                 delay = self.max_revive_delay
                 if self.randomize:
-                    delay = random.randrange(0.0, self.max_revive_delay)
+                    delay = random.uniform(0.0, self.max_revive_delay)
 
                 self.log('waiting for {delay} secs before reviving {label}'.format(
                     delay=delay, label=label))
@@ -334,17 +334,17 @@ class MDSThrasher(ThrasherGreenlet):
              # don't do replay thrashing right now
 #            for info in status.get_replays(self.fs.id):
 #                # this might race with replay -> active transition...
-#                if status['state'] == 'up:replay' and random.randrange(0.0, 1.0) < self.thrash_in_replay:
+#                if status['state'] == 'up:replay' and random.uniform(0.0, 1.0) < self.thrash_in_replay:
 #                    delay = self.max_replay_thrash_delay
 #                    if self.randomize:
-#                        delay = random.randrange(0.0, self.max_replay_thrash_delay)
+#                        delay = random.uniform(0.0, self.max_replay_thrash_delay)
 #                sleep(delay)
 #                self.log('kill replaying mds.{id}'.format(id=self.to_kill))
 #                self.kill_mds(self.to_kill)
 #
 #                delay = self.max_revive_delay
 #                if self.randomize:
-#                    delay = random.randrange(0.0, self.max_revive_delay)
+#                    delay = random.uniform(0.0, self.max_revive_delay)
 #
 #                self.log('waiting for {delay} secs before reviving mds.{id}'.format(
 #                    delay=delay, id=self.to_kill))