]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mon: LogMonitor: check return value when writing to file
authorJoao Eduardo Luis <joao.luis@inktank.com>
Wed, 17 Oct 2012 14:41:36 +0000 (15:41 +0100)
committerJoao Eduardo Luis <joao.luis@inktank.com>
Wed, 17 Oct 2012 14:41:36 +0000 (15:41 +0100)
CID 716851: Unchecked return value (CHECKED_RETURN)
At (51): Calling function "ceph::buffer::list::write_fd(int) const"
without checking return value.

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
src/mon/LogMonitor.cc

index 84dda7dd6147954f75dbb51814cb1999cf8bdb9c..f06de5217a0c403b0aea98456ab085769b3b0a6e 100644 (file)
@@ -150,7 +150,11 @@ void LogMonitor::update_from_paxos()
       int err = -errno;
       dout(1) << "unable to write to " << g_conf->mon_cluster_log_file << ": " << cpp_strerror(err) << dendl;
     } else {
-      blog.write_fd(fd);
+      int err = blog.write_fd(fd);
+      if (err < 0) {
+       dout(1) << "error writing to " << g_conf->mon_cluster_log_file
+               << ": " << cpp_strerror(err) << dendl;
+      }
       TEMP_FAILURE_RETRY(::close(fd));
     }
   }