]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/net: add logging to SocketConnection
authorKefu Chai <kchai@redhat.com>
Wed, 5 Sep 2018 07:50:47 +0000 (15:50 +0800)
committerKefu Chai <kchai@redhat.com>
Thu, 6 Sep 2018 14:03:33 +0000 (22:03 +0800)
Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/net/SocketConnection.cc

index a3d459ca15a47c4e9b46637cab5189f4beef5045..3a9cb1f58345cecdea766a6cbc8fc55d9787806d 100644 (file)
@@ -27,6 +27,8 @@
 #include "auth/AuthSessionHandler.h"
 #include "msg/Message.h"
 
+#include "crimson/common/log.h"
+
 using namespace ceph::net;
 
 template <typename T>
@@ -34,6 +36,12 @@ seastar::net::packet make_static_packet(const T& value) {
     return { reinterpret_cast<const char*>(&value), sizeof(value) };
 }
 
+namespace {
+  seastar::logger& logger() {
+    return ceph::get_logger(ceph_subsys_ms);
+  }
+}
+
 SocketConnection::SocketConnection(Messenger *messenger,
                                    const entity_addr_t& my_addr,
                                    const entity_addr_t& peer_addr,
@@ -663,6 +671,7 @@ seastar::future<> SocketConnection::handle_connect_reply(msgr_tag_t tag)
     return fault();
   case CEPH_MSGR_TAG_BADAUTHORIZER:
     if (h.got_bad_auth) {
+      logger().error("{} got bad authorizer", __func__);
       throw std::system_error(make_error_code(error::negotiation_failure));
     }
     h.got_bad_auth = true;
@@ -724,6 +733,7 @@ seastar::future<> SocketConnection::handle_connect_reply(msgr_tag_t tag)
     return seastar::now();
   } else {
     // unknown tag
+    logger().error("{} got unknown tag", __func__, int(tag));
     throw std::system_error(make_error_code(error::negotiation_failure));
   }
 }
@@ -789,6 +799,7 @@ seastar::future<> SocketConnection::connect(entity_type_t peer_type,
       if (h.authorizer) {
         auto reply = bl.cbegin();
         if (!h.authorizer->verify_reply(reply)) {
+          logger().error("{} authorizer failed to verify reply", __func__);
           throw std::system_error(make_error_code(error::negotiation_failure));
         }
       }