]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
cmake: : link shec_utils against legacy-option-headers 57693/head
authorKefu Chai <tchaikov@gmail.com>
Fri, 24 May 2024 09:51:55 +0000 (17:51 +0800)
committerKefu Chai <tchaikov@gmail.com>
Fri, 24 May 2024 09:53:33 +0000 (17:53 +0800)
in c24a6ffe20, we tried to link all target dependent on legacy option
headers against legacy-option-headers, but we missed some of them.
in our CI, we spotted build failure like:
```
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/erasure-code/ErasureCode.cc:26:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/osd/osd_types.h:41:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/ceph_context.h:41:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config_proxy.h:6:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config.h:27:
In file included from /home/jenkins-build/build/workspace/ceph-pull-requests/src/common/config_values.h:59:
/home/jenkins-build/build/workspace/ceph-pull-requests/src/common/options/legacy_config_opts.h:1:10: fatal error: 'global_legacy_options.h' file not found
         ^~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
```
so in this change, we link the shec_utils to `legacy-option-headers`
as well to fulfill the build dependency.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
src/erasure-code/shec/CMakeLists.txt

index 0e699203d7c2e2e8bf4e873a1e572cbcb0e3de49..e7521542e31112e36454f0b3da8221ca1493628a 100644 (file)
@@ -10,6 +10,8 @@ set(shec_utils_srcs
   determinant.c)
 
 add_library(shec_utils OBJECT ${shec_utils_srcs})
+target_link_libraries(shec_utils
+  PRIVATE legacy-option-headers)
 
 set(ec_shec_objs
   $<TARGET_OBJECTS:gf-complete_objs>