]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mon: fix health store size growing infinitely 55549/head
authorWei Wang <lightmelodies@outlook.com>
Mon, 29 Jan 2024 08:26:24 +0000 (08:26 +0000)
committerKonstantin Shalygin <k0ste@k0ste.ru>
Tue, 12 Mar 2024 05:04:18 +0000 (12:04 +0700)
The `check_mutes` wrongly marks `changed` to true, trigger `propose_pending` and block following `maybe_trim` logic (`have_pending` will be always be false); as a result, the health store will never be trimmed.

Signed-off-by: Wei Wang <lightmelodies@outlook.com>
(cherry picked from commit 05a85848a01c443d67564a9904a778acfe19cee5)

src/mon/HealthMonitor.cc

index 6eed2b0f05bc35d1b5406e1b41960505fb433f9c..0c42734ef481745d92dbf8457d25e4edc7165281 100644 (file)
@@ -400,7 +400,7 @@ void HealthMonitor::tick()
 
 bool HealthMonitor::check_mutes()
 {
-  bool changed = true;
+  bool changed = false;
   auto now = ceph_clock_now();
   health_check_map_t all;
   gather_all_health_checks(&all);