]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
osd/scheduler: add missing breaks in PGRecoveryMsg::run 69743/head
authorSun Yuechi <sunyuechi@iscas.ac.cn>
Thu, 25 Jun 2026 13:39:11 +0000 (21:39 +0800)
committerKefu Chai <k.chai@proxmox.com>
Sat, 27 Jun 2026 13:08:40 +0000 (21:08 +0800)
Without these breaks the switch fell through, recording a single
message's latency into every following per-type counter.

Fixes: https://tracker.ceph.com/issues/77751
Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>
src/osd/scheduler/OpSchedulerItem.cc

index 7ed99a6009806541a95d96da52617fc126f27c94..f1d23c4e728ab06061b8cd320f6f2bf763244d2b 100644 (file)
@@ -214,16 +214,22 @@ void PGRecoveryMsg::run(
   switch (op->get_req()->get_type()) {
   case MSG_OSD_PG_PUSH:
     osd->logger->tinc(l_osd_recovery_push_queue_lat, latency);
+    break;
   case MSG_OSD_PG_PUSH_REPLY:
     osd->logger->tinc(l_osd_recovery_push_reply_queue_lat, latency);
+    break;
   case MSG_OSD_PG_PULL:
     osd->logger->tinc(l_osd_recovery_pull_queue_lat, latency);
+    break;
   case MSG_OSD_PG_BACKFILL:
     osd->logger->tinc(l_osd_recovery_backfill_queue_lat, latency);
+    break;
   case MSG_OSD_PG_BACKFILL_REMOVE:
     osd->logger->tinc(l_osd_recovery_backfill_remove_queue_lat, latency);
+    break;
   case MSG_OSD_PG_SCAN:
     osd->logger->tinc(l_osd_recovery_scan_queue_lat, latency);
+    break;
   }
   osd->dequeue_op(pg, op, handle);
   pg->unlock();