]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
common/TrackedOp: get duration just once when inserting
authorPiotr Dałek <piotr.dalek@corp.ovh.com>
Tue, 20 Feb 2018 14:02:18 +0000 (15:02 +0100)
committerPiotr Dałek <piotr.dalek@corp.ovh.com>
Tue, 20 Feb 2018 14:02:18 +0000 (15:02 +0100)
No need to do this twice.

Signed-off-by: Piotr Dałek <piotr.dalek@corp.ovh.com>
src/common/TrackedOp.cc

index 7653673948d9b99b3c3cc9ce04bbd33f45a45d6e..baf081d0dd4dc929cf14725198058fb4867fad87 100644 (file)
@@ -36,9 +36,10 @@ void OpHistory::insert(utime_t now, TrackedOpRef op)
   Mutex::Locker history_lock(ops_history_lock);
   if (shutdown)
     return;
-  duration.insert(make_pair(op->get_duration(), op));
+  double opduration = op->get_duration();
+  duration.insert(make_pair(opduration, op));
   arrived.insert(make_pair(op->get_initiated(), op));
-  if (op->get_duration() >= history_slow_op_threshold)
+  if (opduration >= history_slow_op_threshold)
     slow_op.insert(make_pair(op->get_initiated(), op));
   cleanup(now);
 }