mgr/cephadm: avoid racing updates to spec dict

Signed-off-by: Sage Weil <sage@redhat.com>

diff --git a/src/pybind/mgr/cephadm/module.py b/src/pybind/mgr/cephadm/module.py
index 35b7fbaacd2842cc981c684994812611b6744a41..1c6ed178cae9831adf560b92e1487f1264731be8 100644 (file)
--- a/src/pybind/mgr/cephadm/module.py
+++ b/src/pybind/mgr/cephadm/module.py
@@ -2185,7 +2185,10 @@ class CephadmOrchestrator(orchestrator.Orchestrator, MgrModule):
 
     def _apply_all_services(self):
         r = False
+        specs = [] # type: List[orchestrator.ServiceSpec]
         for sn, spec in self.spec_store.specs.items():
+            specs.append(spec)
+        for spec in specs:
             try:
                 if self._apply_service(spec):
                     r = True