mgr/dashboard: RGW user E2E Tests

Tests creating, editing and deleting RGW users.
Tests providing invalid input to user creation and editing forms.

Fixes: https://tracker.ceph.com/issues/40364
Fixes: https://tracker.ceph.com/issues/40908
Signed-off-by: Adam King <adking@redhat.com>
Signed-off-by: Rafael Quintero <rquinter@redhat.com>

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/rgw/users.e2e-spec.ts b/src/pybind/mgr/dashboard/frontend/e2e/rgw/users.e2e-spec.ts
index 29baee7313b47b03d0c8da3a320fe9ac8d0fb336..d096a8fc940f93c17dcb87996c3b41d58620363f 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/rgw/users.e2e-spec.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/rgw/users.e2e-spec.ts
@@ -2,6 +2,7 @@ import { Helper } from '../helper.po';
 
 describe('RGW users page', () => {
   let users;
+  const user_name = '000user_create_edit_delete';
 
   beforeAll(() => {
     users = new Helper().users;
@@ -20,4 +21,39 @@ describe('RGW users page', () => {
       expect(users.getBreadcrumbText()).toEqual('Users');
     });
   });
+
+  describe('create, edit & delete user test', () => {
+    beforeAll(() => {
+      users.navigateTo();
+    });
+
+    it('should create user', () => {
+      users.create(user_name, 'Some Name', 'original@website.com', '1200');
+      expect(users.getTableCell(user_name).isPresent()).toBe(true);
+    });
+
+    it('should edit users full name, email and max buckets', () => {
+      users.edit(user_name, 'Another Identity', 'changed@othersite.com', '1969');
+      // checks for succsessful editing are done within edit function
+    });
+
+    it('should delete user', () => {
+      users.delete(user_name);
+      expect(users.getTableCell(user_name).isPresent()).toBe(false);
+    });
+  });
+
+  describe('Invalid input test', () => {
+    beforeAll(() => {
+      users.navigateTo();
+    });
+
+    it('should put invalid input into user creation form and check fields are marked invalid', () => {
+      users.invalidCreate();
+    });
+
+    it('should put invalid input into user edit form and check fields are marked invalid', () => {
+      users.invalidEdit();
+    });
+  });
 });

diff --git a/src/pybind/mgr/dashboard/frontend/e2e/rgw/users.po.ts b/src/pybind/mgr/dashboard/frontend/e2e/rgw/users.po.ts
index 2ded62dbf77190a4ca2b03019bc24458d1ec8835..a8a8189ba307312b157ea9c7bf2398605df85e59 100644 (file)
--- a/src/pybind/mgr/dashboard/frontend/e2e/rgw/users.po.ts
+++ b/src/pybind/mgr/dashboard/frontend/e2e/rgw/users.po.ts
@@ -1,5 +1,234 @@
+import { $, browser, by, element } from 'protractor';
+import { protractor } from 'protractor/built/ptor';
+import { Helper } from '../helper.po';
 import { PageHelper } from '../page-helper.po';
 
 export class UsersPageHelper extends PageHelper {
-  pages = { index: '/#/rgw/user' };
+  pages = {
+    index: '/#/rgw/user',
+    create: '/#/rgw/user/create'
+  };
+
+  create(username, fullname, email, maxbuckets) {
+    this.navigateTo('create');
+
+    expect(this.getBreadcrumbText()).toBe('Create');
+
+    // Enter in  username
+    element(by.id('uid')).sendKeys(username);
+
+    // Enter in full name
+    this.moveClick(element(by.id('display_name')));
+    element(by.id('display_name')).sendKeys(fullname);
+
+    // Enter in email
+    this.moveClick(element(by.id('email')));
+    element(by.id('email')).sendKeys(email);
+
+    // Eneter max buckets
+    this.moveClick(element(by.id('max_buckets')));
+    element(by.id('max_buckets')).clear();
+    element(by.id('max_buckets')).sendKeys(maxbuckets);
+
+    // Click the create button and wait for user to be made
+    const createButton = element(by.cssContainingText('button', 'Create User'));
+    this.moveClick(createButton).then(() => {
+      browser.wait(Helper.EC.presenceOf(this.getTableCell(username)), 10000);
+    });
+  }
+
+  edit(name, new_fullname, new_email, new_maxbuckets) {
+    this.navigateTo();
+
+    browser.wait(Helper.EC.elementToBeClickable(this.getTableCell(name)), 10000); // wait for table to load
+    this.getTableCell(name).click(); // click on the bucket you want to edit in the table
+    element(by.cssContainingText('button', 'Edit')).click(); // click button to move to edit page
+
+    expect(this.getBreadcrumbText()).toEqual('Edit');
+
+    // Change the full name field
+    this.moveClick(element(by.id('display_name')));
+    element(by.id('display_name')).clear();
+    element(by.id('display_name')).sendKeys(new_fullname);
+
+    // Change the email field
+    this.moveClick(element(by.id('email')));
+    element(by.id('email')).clear();
+    element(by.id('email')).sendKeys(new_email);
+
+    // Change the max buckets field
+    this.moveClick(element(by.id('max_buckets')));
+    element(by.id('max_buckets')).clear();
+    element(by.id('max_buckets')).sendKeys(new_maxbuckets);
+
+    const editbutton = element(by.cssContainingText('button', 'Edit User'));
+    this.moveClick(editbutton).then(() => {
+      browser.wait(Helper.EC.elementToBeClickable(this.getTableCell(name)), 10000).then(() => {
+        // Click the user and check its details table for updated content
+        this.getTableCell(name).click();
+        expect($('.active.tab-pane').getText()).toMatch(new_fullname); // check full name was changed
+        expect($('.active.tab-pane').getText()).toMatch(new_email); // check email was changed
+        expect($('.active.tab-pane').getText()).toMatch(new_maxbuckets); // check max buckets was changed
+      });
+    });
+  }
+
+  delete(name) {
+    this.navigateTo();
+
+    // wait for table to load
+    const my_user = this.getFirstTableCellWithText(name);
+    browser.wait(Helper.EC.elementToBeClickable(my_user), 10000);
+
+    my_user.click(); // click on the user you want to delete in the table
+    $('.table-actions button.dropdown-toggle').click(); // click toggle menu
+    $('li.delete a').click(); // click delete
+
+    // wait for pop-up to be visible (checks for title of pop-up)
+    browser.wait(Helper.EC.visibilityOf($('.modal-title.float-left')), 10000).then(() => {
+      browser.wait(Helper.EC.visibilityOf($('.custom-control-label')), 5000);
+      $('.custom-control-label').click(); // click confirmation checkbox
+      element(by.cssContainingText('button', 'Delete user'))
+        .click()
+        .then(() => {
+          browser.wait(
+            Helper.EC.not(Helper.EC.presenceOf(this.getFirstTableCellWithText(name))),
+            10000
+          );
+        });
+    });
+  }
+
+  invalidCreate() {
+    const uname = '000invalid_create_user';
+    // creating this user in order to check that you can't give two users the same name
+    this.create(uname, 'xxx', 'xxx@xxx', '1');
+
+    this.navigateTo('create');
+
+    const username_field = element(by.id('uid'));
+
+    // No username had been entered. Field should be invalid
+    expect(username_field.getAttribute('class')).toContain('ng-invalid');
+
+    // Try to give user already taken name. Should make field invalid.
+    username_field.clear().then(() => {
+      username_field.sendKeys(uname).then(() => {
+        browser
+          .wait(function() {
+            return username_field.getAttribute('class').then(function(classValue) {
+              return classValue.indexOf('ng-pending') === -1;
+            });
+          }, 6000)
+          .then(() => {
+            expect(username_field.getAttribute('class')).toContain('ng-invalid');
+            this.moveClick(element(by.id('display_name'))); // trigger validation check
+            expect(element(by.css('#uid + .invalid-feedback')).getText()).toMatch(
+              'The chosen user ID is already in use.'
+            );
+          });
+      });
+    });
+
+    // check that username field is marked invalid if username has been cleared off
+    for (let i = 0; i < uname.length; i++) {
+      username_field.sendKeys(protractor.Key.BACK_SPACE);
+    }
+    expect(username_field.getAttribute('class')).toContain('ng-invalid');
+    this.moveClick(element(by.id('display_name'))); // trigger validation check
+    expect(element(by.css('#uid + .invalid-feedback')).getText()).toMatch(
+      'This field is required.'
+    );
+
+    // No display name has been given so field should be invalid
+    expect(element(by.id('display_name')).getAttribute('class')).toContain('ng-invalid');
+
+    // display name field should also be marked invalid if given input then emptied
+    this.moveClick(element(by.id('display_name')));
+    element(by.id('display_name')).sendKeys('a');
+    element(by.id('display_name')).sendKeys(protractor.Key.BACK_SPACE);
+    expect(element(by.id('display_name')).getAttribute('class')).toContain('ng-invalid');
+    this.moveClick(username_field); // trigger validation check
+    expect(element(by.css('#display_name + .invalid-feedback')).getText()).toMatch(
+      'This field is required.'
+    );
+
+    // put invalid email to make field invalid
+    this.moveClick(element(by.id('email')));
+    element(by.id('email')).sendKeys('a');
+    expect(element(by.id('email')).getAttribute('class')).toContain('ng-invalid');
+    this.moveClick(username_field); // trigger validation check
+    expect(element(by.css('#email + .invalid-feedback')).getText()).toMatch(
+      'This is not a valid email address.'
+    );
+
+    // put negative max buckets to make field invalid
+    this.moveClick(element(by.id('max_buckets')));
+    element(by.id('max_buckets')).clear();
+    element(by.id('max_buckets')).sendKeys('-5');
+    expect(element(by.id('max_buckets')).getAttribute('class')).toContain('ng-invalid');
+    this.moveClick(username_field); // trigger validation check
+    expect(element(by.css('#max_buckets + .invalid-feedback')).getText()).toMatch(
+      'The entered value must be >= 0.'
+    );
+
+    this.delete(uname);
+  }
+
+  invalidEdit() {
+    const uname = '000invalid_edit_user';
+    // creating this user to edit for the test
+    this.create(uname, 'xxx', 'xxx@xxx', '1');
+
+    this.navigateTo();
+
+    browser.wait(Helper.EC.elementToBeClickable(this.getTableCell(uname)), 10000); // wait for table to load
+    this.getTableCell(uname).click(); // click on the bucket you want to edit in the table
+    element(by.cssContainingText('button', 'Edit')).click(); // click button to move to edit page
+
+    expect(this.getBreadcrumbText()).toEqual('Edit');
+
+    // put invalid email to make field invalid
+    this.moveClick(element(by.id('email')));
+    element(by.id('email')).clear();
+    element(by.id('email')).sendKeys('a');
+    browser
+      .wait(function() {
+        return element(by.id('email'))
+          .getAttribute('class')
+          .then(function(classValue) {
+            return classValue.indexOf('ng-pending') === -1;
+          });
+      }, 6000)
+      .then(() => {
+        expect(element(by.id('email')).getAttribute('class')).toContain('ng-invalid');
+        this.moveClick(element(by.id('display_name'))); // trigger validation check
+        expect(element(by.css('#email + .invalid-feedback')).getText()).toMatch(
+          'This is not a valid email address.'
+        );
+      });
+
+    // empty the display name field making it invalid
+    this.moveClick(element(by.id('display_name')));
+    for (let i = 0; i < 3; i++) {
+      element(by.id('display_name')).sendKeys(protractor.Key.BACK_SPACE);
+    }
+    expect(element(by.id('display_name')).getAttribute('class')).toContain('ng-invalid');
+    this.moveClick(element(by.id('email'))); // trigger validation check
+    expect(element(by.css('#display_name + .invalid-feedback')).getText()).toMatch(
+      'This field is required.'
+    );
+
+    // put negative max buckets to make field invalid
+    this.moveClick(element(by.id('max_buckets')));
+    element(by.id('max_buckets')).clear();
+    element(by.id('max_buckets')).sendKeys('-5');
+    expect(element(by.id('max_buckets')).getAttribute('class')).toContain('ng-invalid');
+    this.moveClick(element(by.id('email'))); // trigger validation check
+    expect(element(by.css('#max_buckets + .invalid-feedback')).getText()).toMatch(
+      'The entered value must be >= 0.'
+    );
+
+    this.delete(uname);
+  }
 }