]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mon: fix health store size growing infinitely 55347/head
authorWei Wang <lightmelodies@outlook.com>
Mon, 29 Jan 2024 08:26:24 +0000 (08:26 +0000)
committerWei Wang <lightmelodies@outlook.com>
Mon, 29 Jan 2024 08:26:24 +0000 (08:26 +0000)
The `check_mutes` wrongly marks `changed` to true, trigger `propose_pending` and block following `maybe_trim` logic (`have_pending` will be always be false); as a result, the health store will never be trimmed.

Signed-off-by: Wei Wang <lightmelodies@outlook.com>
src/mon/HealthMonitor.cc

index 2a21b99111a515654772cda2cf1f27c48a6acce6..4d2303d09fbcf1da510b5e930ac2e071d70a105c 100644 (file)
@@ -400,7 +400,7 @@ void HealthMonitor::tick()
 
 bool HealthMonitor::check_mutes()
 {
-  bool changed = true;
+  bool changed = false;
   auto now = ceph_clock_now();
   health_check_map_t all;
   gather_all_health_checks(&all);