mds/SnapClient: un-inline encoding methods reduce header dependencies

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

diff --git a/src/mds/SnapClient.cc b/src/mds/SnapClient.cc
index 8abce82b9a0a5cfb6d27b047e103747134508638..db40e2841893b5e73b37b1bbf982b26bc4546842 100644 (file)
--- a/src/mds/SnapClient.cc
+++ b/src/mds/SnapClient.cc
@@ -145,6 +145,46 @@ void SnapClient::notify_commit(version_t tid)
   }
 }
 
+void SnapClient::prepare_create(inodeno_t dirino, std::string_view name, utime_t stamp,
+                               version_t *pstid, bufferlist *pbl, MDSContext *onfinish) {
+  bufferlist bl;
+  __u32 op = TABLE_OP_CREATE;
+  encode(op, bl);
+  encode(dirino, bl);
+  encode(name, bl);
+  encode(stamp, bl);
+  _prepare(bl, pstid, pbl, onfinish);
+}
+
+void SnapClient::prepare_create_realm(inodeno_t ino, version_t *pstid, bufferlist *pbl, MDSContext *onfinish) {
+  bufferlist bl;
+  __u32 op = TABLE_OP_CREATE;
+  encode(op, bl);
+  encode(ino, bl);
+  _prepare(bl, pstid, pbl, onfinish);
+}
+
+void SnapClient::prepare_destroy(inodeno_t ino, snapid_t snapid, version_t *pstid, bufferlist *pbl, MDSContext *onfinish) {
+  bufferlist bl;
+  __u32 op = TABLE_OP_DESTROY;
+  encode(op, bl);
+  encode(ino, bl);
+  encode(snapid, bl);
+  _prepare(bl, pstid, pbl, onfinish);
+}
+
+void SnapClient::prepare_update(inodeno_t ino, snapid_t snapid, std::string_view name, utime_t stamp,
+                               version_t *pstid, MDSContext *onfinish) {
+  bufferlist bl;
+  __u32 op = TABLE_OP_UPDATE;
+  encode(op, bl);
+  encode(ino, bl);
+  encode(snapid, bl);
+  encode(name, bl);
+  encode(stamp, bl);
+  _prepare(bl, pstid, NULL, onfinish);
+}
+
 void SnapClient::refresh(version_t want, MDSContext *onfinish)
 {
   dout(10) << __func__ << " want " << want << dendl;

diff --git a/src/mds/SnapClient.h b/src/mds/SnapClient.h
index 7e891dbc1a178face924d6c8b6b36089b17209ba..970f078421d37a3514231de8149fd3cb87326ffa 100644 (file)
--- a/src/mds/SnapClient.h
+++ b/src/mds/SnapClient.h
@@ -39,44 +39,14 @@ public:
   void notify_commit(version_t tid) override;
 
   void prepare_create(inodeno_t dirino, std::string_view name, utime_t stamp,
-                     version_t *pstid, bufferlist *pbl, MDSContext *onfinish) {
-    bufferlist bl;
-    __u32 op = TABLE_OP_CREATE;
-    encode(op, bl);
-    encode(dirino, bl);
-    encode(name, bl);
-    encode(stamp, bl);
-    _prepare(bl, pstid, pbl, onfinish);
-  }
+                     version_t *pstid, bufferlist *pbl, MDSContext *onfinish);
 
-  void prepare_create_realm(inodeno_t ino, version_t *pstid, bufferlist *pbl, MDSContext *onfinish) {
-    bufferlist bl;
-    __u32 op = TABLE_OP_CREATE;
-    encode(op, bl);
-    encode(ino, bl);
-    _prepare(bl, pstid, pbl, onfinish);
-  }
+  void prepare_create_realm(inodeno_t ino, version_t *pstid, bufferlist *pbl, MDSContext *onfinish);
 
-  void prepare_destroy(inodeno_t ino, snapid_t snapid, version_t *pstid, bufferlist *pbl, MDSContext *onfinish) {
-    bufferlist bl;
-    __u32 op = TABLE_OP_DESTROY;
-    encode(op, bl);
-    encode(ino, bl);
-    encode(snapid, bl);
-    _prepare(bl, pstid, pbl, onfinish);
-  }
+  void prepare_destroy(inodeno_t ino, snapid_t snapid, version_t *pstid, bufferlist *pbl, MDSContext *onfinish);
 
   void prepare_update(inodeno_t ino, snapid_t snapid, std::string_view name, utime_t stamp,
-                     version_t *pstid, MDSContext *onfinish) {
-    bufferlist bl;
-    __u32 op = TABLE_OP_UPDATE;
-    encode(op, bl);
-    encode(ino, bl);
-    encode(snapid, bl);
-    encode(name, bl);
-    encode(stamp, bl);
-    _prepare(bl, pstid, NULL, onfinish);
-  }
+                     version_t *pstid, MDSContext *onfinish);
 
   version_t get_cached_version() const { return cached_version; }
   void refresh(version_t want, MDSContext *onfinish);