]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
test/rbd_mirror: do not capture unused variables
authorKefu Chai <kchai@redhat.com>
Tue, 3 Mar 2020 04:01:58 +0000 (12:01 +0800)
committerKefu Chai <kchai@redhat.com>
Tue, 3 Mar 2020 13:11:39 +0000 (21:11 +0800)
this silences warning from clang-11, like

```
../src/test/rbd_mirror/test_mock_ImageReplayer.cc:322:26: warning: lambda capture 'mock_replayer' is not used [-Wunused-lambda-capture]
      .WillOnce(Invoke([&mock_replayer, r](Context* ctx) {
                        ~^~~~~~~~~~~~~~
```

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/test/rbd_mirror/image_replayer/test_mock_BootstrapRequest.cc
src/test/rbd_mirror/test_mock_ImageReplayer.cc

index 049187fcf78b57f90f13043682221d1feeeedb37..8175680ab6c86ec86865c896b4c9c4bd8cf23be3 100644 (file)
@@ -397,7 +397,7 @@ public:
   void expect_close_remote_image(
       MockStateBuilder& mock_state_builder, int r) {
     EXPECT_CALL(mock_state_builder, close_remote_image(_))
-      .WillOnce(Invoke([this, &mock_state_builder, r]
+      .WillOnce(Invoke([&mock_state_builder, r]
                        (Context* on_finish) {
           mock_state_builder.remote_image_ctx = nullptr;
           on_finish->complete(r);
@@ -409,7 +409,7 @@ public:
     EXPECT_CALL(mock_state_builder,
                 create_local_image_request(_, _, _, _, _, _))
       .WillOnce(WithArg<5>(
-        Invoke([this, &mock_state_builder, local_image_id, r](Context* ctx) {
+        Invoke([&mock_state_builder, local_image_id, r](Context* ctx) {
           if (r >= 0) {
             mock_state_builder.local_image_id = local_image_id;
           }
@@ -428,7 +428,7 @@ public:
     EXPECT_CALL(mock_state_builder,
                 create_prepare_replay_request(_, _, _, _, _))
       .WillOnce(WithArgs<2, 3, 4>(
-        Invoke([this, &mock_state_builder, resync_requested, syncing, r]
+        Invoke([&mock_state_builder, resync_requested, syncing, r]
                (bool* resync, bool* sync, Context* ctx) {
           if (r >= 0) {
             *resync = resync_requested;
index 0f4579bbe8e64de6612e8565a8a050bab779ce2d..653b6e98bb7c515d1424f83eed8b7d94e6a7b8c6 100644 (file)
@@ -303,7 +303,7 @@ public:
                               MockReplayer& mock_replayer) {
     EXPECT_CALL(mock_state_builder, create_replayer(_, _, _, _))
       .WillOnce(WithArg<3>(
-        Invoke([this, &mock_replayer]
+        Invoke([&mock_replayer]
                (image_replayer::ReplayerListener* replayer_listener) {
           mock_replayer.replayer_listener = replayer_listener;
           return &mock_replayer;
@@ -319,14 +319,14 @@ public:
 
   void expect_init(MockReplayer& mock_replayer, int r) {
     EXPECT_CALL(mock_replayer, init(_))
-      .WillOnce(Invoke([this, &mock_replayer, r](Context* ctx) {
+      .WillOnce(Invoke([this, r](Context* ctx) {
                   m_threads->work_queue->queue(ctx, r);
                 }));
   }
 
   void expect_shut_down(MockReplayer& mock_replayer, int r) {
     EXPECT_CALL(mock_replayer, shut_down(_))
-      .WillOnce(Invoke([this, &mock_replayer, r](Context* ctx) {
+      .WillOnce(Invoke([this, r](Context* ctx) {
                   m_threads->work_queue->queue(ctx, r);
                 }));
     EXPECT_CALL(mock_replayer, destroy());