msg: Change crimson's make_message() namespace to crimson

instead of crimson::net so we can use TOPNSPC namespace in shared parts
between crimson-osd and ceph-osd

Signed-off-by: Amnon Hanuhov <ahanukov@redhat.com>

diff --git a/src/crimson/admin/admin_socket.cc b/src/crimson/admin/admin_socket.cc
index 2f064ec47ffe01dfed340e3d2920779eb78ad723..136adb41a724f94dc37f8b9768f2191e8836d295 100644 (file)
--- a/src/crimson/admin/admin_socket.cc
+++ b/src/crimson/admin/admin_socket.cc
@@ -131,7 +131,7 @@ seastar::future<> AdminSocket::handle_command(crimson::net::ConnectionRef conn,
   return execute_command(m->cmd, std::move(m->get_data())).then(
     [conn, tid=m->get_tid()](auto result) {
     auto [ret, err, out] = std::move(result);
-    auto reply = crimson::net::make_message<MCommandReply>(ret, err);
+    auto reply = crimson::make_message<MCommandReply>(ret, err);
     reply->set_tid(tid);
     reply->set_data(out);
     return conn->send(std::move(reply));

diff --git a/src/crimson/mon/MonClient.cc b/src/crimson/mon/MonClient.cc
index 5975c9b4460e1fadd75aeee508c298784008a1c4..99aeae9d353a8b5364f9ef0ab47471ba361f85ec 100644 (file)
--- a/src/crimson/mon/MonClient.cc
+++ b/src/crimson/mon/MonClient.cc
@@ -203,7 +203,7 @@ Connection::create_auth(crimson::auth::method_t protocol,
 seastar::future<std::optional<Connection::auth_result_t>>
 Connection::do_auth_single(Connection::request_t what)
 {
-  auto m = crimson::net::make_message<MAuth>();
+  auto m = crimson::make_message<MAuth>();
   m->protocol = auth->get_protocol();
   auth->prepare_build_request();
   switch (what) {
@@ -267,7 +267,7 @@ Connection::do_auth(Connection::request_t what) {
 seastar::future<Connection::auth_result_t> Connection::authenticate_v2()
 {
   auth_start = seastar::lowres_system_clock::now();
-  return conn->send(crimson::net::make_message<MMonGetMap>()).then([this] {
+  return conn->send(crimson::make_message<MMonGetMap>()).then([this] {
     auth_done.emplace();
     return auth_done->get_future();
   });
@@ -800,7 +800,7 @@ seastar::future<> Client::handle_subscribe_ack(Ref<MMonSubscribeAck> m)
 
 Client::get_version_t Client::get_version(const std::string& map)
 {
-  auto m = crimson::net::make_message<MMonGetVersion>();
+  auto m = crimson::make_message<MMonGetVersion>();
   auto tid = ++last_version_req_id;
   m->handle = tid;
   m->what = map;
@@ -1020,12 +1020,12 @@ Client::command_result_t
 Client::run_command(std::string&& cmd,
                     bufferlist&& bl)
 {
-  auto m = crimson::net::make_message<MMonCommand>(monmap.fsid);
+  auto m = crimson::make_message<MMonCommand>(monmap.fsid);
   auto tid = ++last_mon_command_id;
   m->set_tid(tid);
   m->cmd = {std::move(cmd)};
   m->set_data(std::move(bl));
-  auto& command = mon_commands.emplace_back(make_message<MMonCommand>(*m));
+  auto& command = mon_commands.emplace_back(ceph::make_message<MMonCommand>(*m));
   return send_message(std::move(m)).then([&result=command.result] {
     return result.get_future();
   });
@@ -1057,7 +1057,7 @@ seastar::future<> Client::on_session_opened()
   }).then([this] {
     return seastar::parallel_for_each(mon_commands,
       [this](auto &command) {
-      return send_message(crimson::net::make_message<MMonCommand>(*command.req));
+      return send_message(crimson::make_message<MMonCommand>(*command.req));
     });
   });
 }
@@ -1092,7 +1092,7 @@ seastar::future<> Client::renew_subs()
   }
   logger().trace("{}", __func__);
 
-  auto m = crimson::net::make_message<MMonSubscribe>();
+  auto m = crimson::make_message<MMonSubscribe>();
   m->what = sub.get_subs();
   m->hostname = ceph_get_short_hostname();
   return send_message(std::move(m)).then([this] {

diff --git a/src/crimson/osd/heartbeat.cc b/src/crimson/osd/heartbeat.cc
index 3b8b3b6614f5068f1b64129f88469917d0da44b0..53723f0a7444d2a2b04e1bc69e6bb4febe153c70 100644 (file)
--- a/src/crimson/osd/heartbeat.cc
+++ b/src/crimson/osd/heartbeat.cc
@@ -279,7 +279,7 @@ seastar::future<> Heartbeat::handle_ping(crimson::net::ConnectionRef conn,
   auto min_message = static_cast<uint32_t>(
     local_conf()->osd_heartbeat_min_size);
   auto reply =
-    crimson::net::make_message<MOSDPing>(
+    crimson::make_message<MOSDPing>(
       m->fsid,
       service.get_osdmap_service().get_map()->get_epoch(),
       MOSDPing::PING_REPLY,
@@ -613,7 +613,7 @@ void Heartbeat::Peer::do_send_heartbeat(
   for_each_conn([&, this] (auto& conn) {
     auto min_message = static_cast<uint32_t>(
       local_conf()->osd_heartbeat_min_size);
-    auto ping = crimson::net::make_message<MOSDPing>(
+    auto ping = crimson::make_message<MOSDPing>(
       heartbeat.monc.get_fsid(),
       heartbeat.service.get_osdmap_service().get_map()->get_epoch(),
       MOSDPing::PING,
@@ -641,7 +641,7 @@ bool Heartbeat::FailingPeers::add_pending(
       now - failed_since).count();
   auto osdmap = heartbeat.service.get_osdmap_service().get_map();
   auto failure_report =
-      crimson::net::make_message<MOSDFailure>(heartbeat.monc.get_fsid(),
+      crimson::make_message<MOSDFailure>(heartbeat.monc.get_fsid(),
                                 peer,
                                 osdmap->get_addrs(peer),
                                 static_cast<int>(failed_for),
@@ -668,7 +668,7 @@ seastar::future<>
 Heartbeat::FailingPeers::send_still_alive(
     osd_id_t osd, const entity_addrvec_t& addrs)
 {
-  auto still_alive = crimson::net::make_message<MOSDFailure>(
+  auto still_alive = crimson::make_message<MOSDFailure>(
     heartbeat.monc.get_fsid(),
     osd,
     addrs,

diff --git a/src/crimson/osd/osd.cc b/src/crimson/osd/osd.cc
index 4a653011396781614cb1722b4db54901f4909f54..5618054e2dce718698e476a79409af234b947b85 100644 (file)
--- a/src/crimson/osd/osd.cc
+++ b/src/crimson/osd/osd.cc
@@ -366,7 +366,7 @@ seastar::future<> OSD::_send_boot()
   logger().info("hb_back_msgr: {}", heartbeat->get_back_addrs());
   logger().info("hb_front_msgr: {}", heartbeat->get_front_addrs());
   logger().info("cluster_msgr: {}", cluster_msgr->get_myaddr());
-  auto m = crimson::net::make_message<MOSDBoot>(superblock,
+  auto m = crimson::make_message<MOSDBoot>(superblock,
                                   osdmap->get_epoch(),
                                   osdmap->get_epoch(),
                                   heartbeat->get_back_addrs(),
@@ -738,7 +738,7 @@ MessageRef OSD::get_stats() const
 {
   // todo: m-to-n: collect stats using map-reduce
   // MPGStats::had_map_for is not used since PGMonitor was removed
-  auto m = make_message<MPGStats>(monc->get_fsid(), osdmap->get_epoch());
+  auto m = ceph::make_message<MPGStats>(monc->get_fsid(), osdmap->get_epoch());
   m->osd_stat = osd_stat;
   for (auto [pgid, pg] : pg_map.get_pgs()) {
     if (pg->is_primary()) {
@@ -1105,7 +1105,7 @@ seastar::future<> OSD::send_incremental_map(crimson::net::ConnectionRef conn,
   if (first >= superblock.oldest_map) {
     return load_map_bls(first, superblock.newest_map)
     .then([this, conn, first](auto&& bls) {
-      auto m = crimson::net::make_message<MOSDMap>(monc->get_fsid(),
+      auto m = crimson::make_message<MOSDMap>(monc->get_fsid(),
          osdmap->get_encoding_features());
       m->oldest_map = first;
       m->newest_map = superblock.newest_map;
@@ -1115,7 +1115,7 @@ seastar::future<> OSD::send_incremental_map(crimson::net::ConnectionRef conn,
   } else {
     return load_map_bl(osdmap->get_epoch())
     .then([this, conn](auto&& bl) mutable {
-      auto m = crimson::net::make_message<MOSDMap>(monc->get_fsid(),
+      auto m = crimson::make_message<MOSDMap>(monc->get_fsid(),
          osdmap->get_encoding_features());
       m->oldest_map = superblock.oldest_map;
       m->newest_map = superblock.newest_map;
@@ -1240,7 +1240,7 @@ seastar::future<> OSD::send_beacon()
   // FIXME: min lec should be calculated from pg_stat
   //        and should set m->pgs
   epoch_t min_last_epoch_clean = osdmap->get_epoch();
-  auto m = crimson::net::make_message<MOSDBeacon>(osdmap->get_epoch(),
+  auto m = crimson::make_message<MOSDBeacon>(osdmap->get_epoch(),
                                     min_last_epoch_clean,
                                     superblock.last_purged_snaps_scrub,
                                     local_conf()->osd_beacon_report_interval);
@@ -1346,7 +1346,7 @@ seastar::future<> OSD::prepare_to_stop()
     return seastar::with_timeout(
       seastar::timer<>::clock::now() + timeout,
       monc->send_message(
-         crimson::net::make_message<MOSDMarkMeDown>(
+         crimson::make_message<MOSDMarkMeDown>(
            monc->get_fsid(),
            whoami,
            osdmap->get_addrs(whoami),

diff --git a/src/crimson/osd/osd_operations/client_request.cc b/src/crimson/osd/osd_operations/client_request.cc
index 9bfc9125400804053f8732bf8df6af069950910e..75f70985af18d1ae3bb8f65ec0d50124c2a78eed 100644 (file)
--- a/src/crimson/osd/osd_operations/client_request.cc
+++ b/src/crimson/osd/osd_operations/client_request.cc
@@ -157,7 +157,7 @@ ClientRequest::process_op(Ref<PG> &pg)
       [this, pg](bool completed, int ret) mutable
       -> PG::load_obc_iertr::future<> {
       if (completed) {
-        auto reply = crimson::net::make_message<MOSDOpReply>(
+        auto reply = crimson::make_message<MOSDOpReply>(
           m.get(), ret, pg->get_osdmap_epoch(),
           CEPH_OSD_FLAG_ACK | CEPH_OSD_FLAG_ONDISK, false);
         return conn->send(std::move(reply));
@@ -196,7 +196,7 @@ ClientRequest::do_process(Ref<PG>& pg, crimson::osd::ObjectContextRef obc)
       return seastar::now();
     } else if (const hobject_t& hoid = m->get_hobj();
                !pg->get_peering_state().can_serve_replica_read(hoid)) {
-      auto reply = crimson::net::make_message<MOSDOpReply>(
+      auto reply = crimson::make_message<MOSDOpReply>(
        m.get(), -EAGAIN, pg->get_osdmap_epoch(),
        m->get_flags() & (CEPH_OSD_FLAG_ACK|CEPH_OSD_FLAG_ONDISK),
        !m->has_flag(CEPH_OSD_FLAG_RETURNVEC));

diff --git a/src/crimson/osd/pg.cc b/src/crimson/osd/pg.cc
index 75936b78c0404e5d2817f142233a7cca36ecd8a8..e921d3803fe512f6fedfb39428898e6b28082a53 100644 (file)
--- a/src/crimson/osd/pg.cc
+++ b/src/crimson/osd/pg.cc
@@ -756,7 +756,7 @@ PG::do_osd_ops(
       if (result > 0 && !rvec) {
         result = 0;
       }
-      auto reply = make_message<MOSDOpReply>(m.get(),
+      auto reply = ceph::make_message<MOSDOpReply>(m.get(),
                                              result,
                                              get_osdmap_epoch(),
                                              0,
@@ -770,7 +770,7 @@ PG::do_osd_ops(
         std::move(reply));
     },
     [m, this] (const std::error_code& e) {
-      auto reply = make_message<MOSDOpReply>(
+      auto reply = ceph::make_message<MOSDOpReply>(
         m.get(), -e.value(), get_osdmap_epoch(), 0, false);
       reply->set_enoent_reply_versions(
         peering_state.get_info().last_update,
@@ -812,12 +812,12 @@ PG::interruptible_future<Ref<MOSDOpReply>> PG::do_pg_ops(Ref<MOSDOp> m)
     logger().debug("will be handling pg op {}", ceph_osd_op_name(osd_op.op.op));
     return ox->execute_op(osd_op);
   }).then_interruptible([m, this, ox = std::move(ox)] {
-    auto reply = make_message<MOSDOpReply>(m.get(), 0, get_osdmap_epoch(),
+    auto reply = ceph::make_message<MOSDOpReply>(m.get(), 0, get_osdmap_epoch(),
                                            CEPH_OSD_FLAG_ACK | CEPH_OSD_FLAG_ONDISK,
                                            false);
     return seastar::make_ready_future<Ref<MOSDOpReply>>(std::move(reply));
   }).handle_exception_type_interruptible([=](const crimson::osd::error& e) {
-    auto reply = make_message<MOSDOpReply>(
+    auto reply = ceph::make_message<MOSDOpReply>(
       m.get(), -e.code().value(), get_osdmap_epoch(), 0, false);
     reply->set_enoent_reply_versions(peering_state.get_info().last_update,
                                     peering_state.get_info().last_user_version);
@@ -1105,7 +1105,7 @@ PG::interruptible_future<> PG::handle_rep_op(Ref<MOSDRepOp> req)
       [req, lcod=peering_state.get_info().last_complete, this] {
       peering_state.update_last_complete_ondisk(lcod);
       const auto map_epoch = get_osdmap_epoch();
-      auto reply = make_message<MOSDRepOpReply>(
+      auto reply = ceph::make_message<MOSDRepOpReply>(
         req.get(), pg_whoami, 0,
        map_epoch, req->get_min_epoch(), CEPH_OSD_FLAG_ONDISK);
       reply->set_last_complete_ondisk(lcod);

diff --git a/src/crimson/osd/pg_recovery.cc b/src/crimson/osd/pg_recovery.cc
index 76e02d32784eabe5d63e4ecbda450a2abbbaf158..1b8c865f21f48aa51c268a911612130a3467c9bd 100644 (file)
--- a/src/crimson/osd/pg_recovery.cc
+++ b/src/crimson/osd/pg_recovery.cc
@@ -403,7 +403,7 @@ void PGRecovery::request_replica_scan(
   const hobject_t& end)
 {
   logger().debug("{}: target.osd={}", __func__, target.osd);
-  auto msg = crimson::net::make_message<MOSDPGScan>(
+  auto msg = crimson::make_message<MOSDPGScan>(
     MOSDPGScan::OP_SCAN_GET_DIGEST,
     pg->get_pg_whoami(),
     pg->get_osdmap_epoch(),
@@ -488,7 +488,7 @@ void PGRecovery::update_peers_last_backfill(
     if (const pg_info_t& pinfo = pg->get_peering_state().get_peer_info(bt);
         new_last_backfill > pinfo.last_backfill) {
       pg->get_peering_state().update_peer_last_backfill(bt, new_last_backfill);
-      auto m = crimson::net::make_message<MOSDPGBackfill>(
+      auto m = crimson::make_message<MOSDPGBackfill>(
         pinfo.last_backfill.is_max() ? MOSDPGBackfill::OP_BACKFILL_FINISH
                                      : MOSDPGBackfill::OP_BACKFILL_PROGRESS,
         pg->get_osdmap_epoch(),

diff --git a/src/crimson/osd/recovery_backend.cc b/src/crimson/osd/recovery_backend.cc
index 5a6e8e0141bd224180d00eabe8b158792fa8e37e..f41b8a3de3462edcb397fd637c893cef17cab2b7 100644 (file)
--- a/src/crimson/osd/recovery_backend.cc
+++ b/src/crimson/osd/recovery_backend.cc
@@ -72,7 +72,7 @@ void RecoveryBackend::handle_backfill_finish(
   logger().debug("{}", __func__);
   ceph_assert(!pg.is_primary());
   ceph_assert(crimson::common::local_conf()->osd_kill_backfill_at != 1);
-  auto reply = crimson::net::make_message<MOSDPGBackfill>(
+  auto reply = crimson::make_message<MOSDPGBackfill>(
     MOSDPGBackfill::OP_BACKFILL_FINISH_ACK,
     pg.get_osdmap_epoch(),
     m.query_epoch,
@@ -232,7 +232,7 @@ RecoveryBackend::handle_scan_get_digest(
   ).then_interruptible([this,
           query_epoch=m.query_epoch,
           conn=m.get_connection()] (auto backfill_interval) {
-    auto reply = crimson::net::make_message<MOSDPGScan>(
+    auto reply = crimson::make_message<MOSDPGScan>(
       MOSDPGScan::OP_SCAN_DIGEST,
       pg.get_pg_whoami(),
       pg.get_osdmap_epoch(),

diff --git a/src/crimson/osd/replicated_backend.cc b/src/crimson/osd/replicated_backend.cc
index 66ebfd2ff4f4682c6a20f509cf4bd14fec0c5cc9..e4a21968b33f223f90ed628cf9140364973dc510 100644 (file)
--- a/src/crimson/osd/replicated_backend.cc
+++ b/src/crimson/osd/replicated_backend.cc
@@ -83,7 +83,7 @@ ReplicatedBackend::_submit_transaction(std::set<pg_shard_t>&& pg_shards,
 
   for (auto pg_shard : pg_shards) {
     if (pg_shard != whoami) {
-      auto m = crimson::net::make_message<MOSDRepOp>(
+      auto m = crimson::make_message<MOSDRepOp>(
        osd_op_p.req_id,
        whoami,
        spg_t{pgid, pg_shard.shard},

diff --git a/src/crimson/osd/replicated_recovery_backend.cc b/src/crimson/osd/replicated_recovery_backend.cc
index 22ac3f6898a96095b4036a0247abbd100ea6b225..79e39c6fed3ef313cc030f9d1d0acff31cd4affe 100644 (file)
--- a/src/crimson/osd/replicated_recovery_backend.cc
+++ b/src/crimson/osd/replicated_recovery_backend.cc
@@ -53,7 +53,7 @@ ReplicatedRecoveryBackend::maybe_push_shards(
   return interruptor::parallel_for_each(get_shards_to_push(soid),
     [this, need, soid](auto shard) {
     return prep_push(soid, need, shard).then_interruptible([this, soid, shard](auto push) {
-      auto msg = crimson::net::make_message<MOSDPGPush>();
+      auto msg = crimson::make_message<MOSDPGPush>();
       msg->from = pg.get_pg_whoami();
       msg->pgid = pg.get_pgid();
       msg->map_epoch = pg.get_osdmap_epoch();
@@ -106,7 +106,7 @@ ReplicatedRecoveryBackend::maybe_pull_missing_obj(
   recovery_waiter.pi = std::make_optional<RecoveryBackend::PullInfo>();
   auto& pi = *recovery_waiter.pi;
   prepare_pull(po, pi, soid, need);
-  auto msg = crimson::net::make_message<MOSDPGPull>();
+  auto msg = crimson::make_message<MOSDPGPull>();
   msg->from = pg.get_pg_whoami();
   msg->set_priority(pg.get_recovery_op_priority());
   msg->pgid = pg.get_pgid();
@@ -144,7 +144,7 @@ ReplicatedRecoveryBackend::push_delete(
       logger().debug("push_delete: will remove {} from {}", soid, shard);
       pg.begin_peer_recover(shard, soid);
       spg_t target_pg(pg.get_info().pgid.pgid, shard.shard);
-      auto msg = crimson::net::make_message<MOSDPGRecoveryDelete>(
+      auto msg = crimson::make_message<MOSDPGRecoveryDelete>(
          pg.get_pg_whoami(), target_pg, pg.get_osdmap_epoch(), min_epoch);
       msg->set_priority(pg.get_recovery_op_priority());
       msg->objects.push_back(std::make_pair(soid, need));
@@ -169,7 +169,7 @@ ReplicatedRecoveryBackend::handle_recovery_delete(
   return local_recover_delete(p.first, p.second, pg.get_osdmap_epoch())
   .then_interruptible(
     [this, m] {
-    auto reply = crimson::net::make_message<MOSDPGRecoveryDeleteReply>();
+    auto reply = crimson::make_message<MOSDPGRecoveryDeleteReply>();
     reply->from = pg.get_pg_whoami();
     reply->set_priority(m->get_priority());
     reply->pgid = spg_t(pg.get_info().pgid.pgid, m->from.shard);
@@ -608,7 +608,7 @@ ReplicatedRecoveryBackend::handle_pull(Ref<MOSDPGPull> m)
         }
         return build_push_op(recovery_info, progress, 0);
       }).then_interruptible([this, from](auto pop) {
-        auto msg = crimson::net::make_message<MOSDPGPush>();
+        auto msg = crimson::make_message<MOSDPGPush>();
         msg->from = pg.get_pg_whoami();
         msg->pgid = pg.get_pgid();
         msg->map_epoch = pg.get_osdmap_epoch();
@@ -738,7 +738,7 @@ ReplicatedRecoveryBackend::handle_pull_response(
        recovering.at(pop.soid).set_pulled();
        return seastar::make_ready_future<>();
       } else {
-       auto reply = crimson::net::make_message<MOSDPGPull>();
+       auto reply = crimson::make_message<MOSDPGPull>();
        reply->from = pg.get_pg_whoami();
        reply->set_priority(m->get_priority());
        reply->pgid = pg.get_info().pgid;
@@ -813,7 +813,7 @@ ReplicatedRecoveryBackend::handle_push(
        });
       });
     }).then_interruptible([this, m, &response]() mutable {
-      auto reply = crimson::net::make_message<MOSDPGPushReply>();
+      auto reply = crimson::make_message<MOSDPGPushReply>();
       reply->from = pg.get_pg_whoami();
       reply->set_priority(m->get_priority());
       reply->pgid = pg.get_info().pgid;
@@ -872,7 +872,7 @@ ReplicatedRecoveryBackend::handle_push_reply(
   return _handle_push_reply(from, push_reply).then_interruptible(
     [this, from](std::optional<PushOp> push_op) {
     if (push_op) {
-      auto msg = crimson::net::make_message<MOSDPGPush>();
+      auto msg = crimson::make_message<MOSDPGPush>();
       msg->from = pg.get_pg_whoami();
       msg->pgid = pg.get_pgid();
       msg->map_epoch = pg.get_osdmap_epoch();

diff --git a/src/crimson/osd/shard_services.cc b/src/crimson/osd/shard_services.cc
index 09246884b573995ed727db333e765ef991136aaa..30afde88270214c3d82e8faede85ee4561307855 100644 (file)
--- a/src/crimson/osd/shard_services.cc
+++ b/src/crimson/osd/shard_services.cc
@@ -206,7 +206,7 @@ seastar::future<> ShardServices::send_pg_temp()
   for (auto& [pgid, pg_temp] : pg_temp_wanted) {
     auto& m = ms[pg_temp.forced];
     if (!m) {
-      m = crimson::net::make_message<MOSDPGTemp>(osdmap->get_epoch());
+      m = crimson::make_message<MOSDPGTemp>(osdmap->get_epoch());
       m->forced = pg_temp.forced;
     }
     m->pg_temp.emplace(pgid, pg_temp.acting);
@@ -239,7 +239,7 @@ seastar::future<> ShardServices::send_pg_created(pg_t pgid)
   auto o = get_osdmap();
   ceph_assert(o->require_osd_release >= ceph_release_t::luminous);
   pg_created.insert(pgid);
-  return monc.send_message(crimson::net::make_message<MOSDPGCreated>(pgid));
+  return monc.send_message(crimson::make_message<MOSDPGCreated>(pgid));
 }
 
 seastar::future<> ShardServices::send_pg_created()
@@ -249,7 +249,7 @@ seastar::future<> ShardServices::send_pg_created()
   ceph_assert(o->require_osd_release >= ceph_release_t::luminous);
   return seastar::parallel_for_each(pg_created,
     [this](auto &pgid) {
-      return monc.send_message(crimson::net::make_message<MOSDPGCreated>(pgid));
+      return monc.send_message(crimson::make_message<MOSDPGCreated>(pgid));
     });
 }
 
@@ -312,7 +312,7 @@ seastar::future<> ShardServices::send_alive(const epoch_t want)
         up_thru_wanted > up_thru) {
     logger().debug("{} up_thru_wanted={} up_thru={}", __func__, want, up_thru);
     return monc.send_message(
-      crimson::net::make_message<MOSDAlive>(osdmap->get_epoch(), want));
+      crimson::make_message<MOSDAlive>(osdmap->get_epoch(), want));
   } else {
     logger().debug("{} {} <= {}", __func__, want, osdmap->get_up_thru(whoami));
     return seastar::now();

diff --git a/src/crimson/osd/watch.cc b/src/crimson/osd/watch.cc
index a5a3c46254039723289cbf3d0c46cfbed8f07ad9..5657a8aeae215af3925c8d64e4f7cdfe83c9f0b9 100644 (file)
--- a/src/crimson/osd/watch.cc
+++ b/src/crimson/osd/watch.cc
@@ -92,7 +92,7 @@ seastar::future<> Watch::connect(crimson::net::ConnectionRef conn, bool)
 seastar::future<> Watch::send_notify_msg(NotifyRef notify)
 {
   logger().info("{} for notify(id={})", __func__, notify->ninfo.notify_id);
-  return conn->send(crimson::net::make_message<MWatchNotify>(
+  return conn->send(crimson::make_message<MWatchNotify>(
     winfo.cookie,
     notify->user_version,
     notify->ninfo.notify_id,
@@ -131,7 +131,7 @@ seastar::future<> Watch::send_disconnect_msg()
     return seastar::now();
   }
   ceph::bufferlist empty;
-  return conn->send(crimson::net::make_message<MWatchNotify>(
+  return conn->send(crimson::make_message<MWatchNotify>(
     winfo.cookie,
     0,
     0,
@@ -259,7 +259,7 @@ seastar::future<> Notify::send_completion(
   logger().debug("{} sending notify replies: {}", __func__, notify_replies);
 
   ceph::bufferlist empty;
-  auto reply = crimson::net::make_message<MWatchNotify>(
+  auto reply = crimson::make_message<MWatchNotify>(
     ninfo.cookie,
     user_version,
     ninfo.notify_id,

diff --git a/src/messages/MCacheExpire.h b/src/messages/MCacheExpire.h
index 260fefde44aeb49b98bc42ca6977d5a9b2e67f2d..a01276b11908ea7c41cade56daf9f946175b9742 100644 (file)
--- a/src/messages/MCacheExpire.h
+++ b/src/messages/MCacheExpire.h
@@ -106,7 +106,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 WRITE_CLASS_ENCODER(MCacheExpire::realm)

diff --git a/src/messages/MClientCapRelease.h b/src/messages/MClientCapRelease.h
index 6eced055187f90035b7f98b54e2947087daafce9..f4302d6bc41683ae5808ed7febe76abc4b3d48e5 100644 (file)
--- a/src/messages/MClientCapRelease.h
+++ b/src/messages/MClientCapRelease.h
@@ -53,7 +53,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 
   static constexpr int HEAD_VERSION = 2;
   static constexpr int COMPAT_VERSION = 1;

diff --git a/src/messages/MClientCaps.h b/src/messages/MClientCaps.h
index 4793ff415f48db73810a1c6434fdea0e035e1f09..500a6fc83b1ae5495f65ca2bccb5737ca4654b82 100644 (file)
--- a/src/messages/MClientCaps.h
+++ b/src/messages/MClientCaps.h
@@ -343,7 +343,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MClientLease.h b/src/messages/MClientLease.h
index 7649e99d1c6b4e62b4a26769c18298a095dbfaf9..e0c1d13c80b82e4f428889614c4b974a1c16df58 100644 (file)
--- a/src/messages/MClientLease.h
+++ b/src/messages/MClientLease.h
@@ -91,7 +91,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MClientMetrics.h b/src/messages/MClientMetrics.h
index 2a8f1f47f82673294d90211c31e60b55e97b6fba..0745f4eaaab598a43335404db68091cfd0732e36 100644 (file)
--- a/src/messages/MClientMetrics.h
+++ b/src/messages/MClientMetrics.h
@@ -50,7 +50,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif // CEPH_MDS_CLIENT_METRICS_H

diff --git a/src/messages/MClientQuota.h b/src/messages/MClientQuota.h
index e13a7894718a7917f678ee9ad3da02aa02bfe1ab..ddad8fbddf03702a448d5e13873b512b7e8570cb 100644 (file)
--- a/src/messages/MClientQuota.h
+++ b/src/messages/MClientQuota.h
@@ -50,7 +50,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MClientReclaim.h b/src/messages/MClientReclaim.h
index 81590c236e645a8afffd74275744cc180149272a..edaf54b6bca506afaac44f379b6795f8f6b0b8fc 100644 (file)
--- a/src/messages/MClientReclaim.h
+++ b/src/messages/MClientReclaim.h
@@ -62,7 +62,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MClientReclaimReply.h b/src/messages/MClientReclaimReply.h
index d51bc835884c2e694774c599cf30d683a692db8b..23d3a51b0ec5b214907aba7b4a79469d2f29b10a 100644 (file)
--- a/src/messages/MClientReclaimReply.h
+++ b/src/messages/MClientReclaimReply.h
@@ -68,7 +68,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MClientReconnect.h b/src/messages/MClientReconnect.h
index a8268acc7b4c76d1fc6073b35d4072893b4bac25..96610b7b3ebb35a6456e8777c6a95c2f9366b495 100644 (file)
--- a/src/messages/MClientReconnect.h
+++ b/src/messages/MClientReconnect.h
@@ -171,7 +171,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 

diff --git a/src/messages/MClientReply.h b/src/messages/MClientReply.h
index f52d1f023275d41c16a1c2d0a372a98cdb295d51..5606b8ced9595c7013ebfcd67837af458a6abb20 100644 (file)
--- a/src/messages/MClientReply.h
+++ b/src/messages/MClientReply.h
@@ -401,7 +401,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MClientRequest.h b/src/messages/MClientRequest.h
index a4e6ec79c52d81341cc665d04287b2e1f7defb5a..1e83ec3af1bdadd483009cab5d9fba16654ceca0 100644 (file)
--- a/src/messages/MClientRequest.h
+++ b/src/messages/MClientRequest.h
@@ -323,7 +323,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 WRITE_CLASS_ENCODER(MClientRequest::Release)

diff --git a/src/messages/MClientRequestForward.h b/src/messages/MClientRequestForward.h
index b48aedb20928fed28ce4ca4efe4322b59b586bb3..a9c2b04dcddf55b9f656d78a7bbce033a078dca5 100644 (file)
--- a/src/messages/MClientRequestForward.h
+++ b/src/messages/MClientRequestForward.h
@@ -68,7 +68,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MClientSession.h b/src/messages/MClientSession.h
index d6a9826a12e1639f1317873c78378598307ad762..d5200cf8273ec40b4fc4de5637eb81f4602c2e97 100644 (file)
--- a/src/messages/MClientSession.h
+++ b/src/messages/MClientSession.h
@@ -95,7 +95,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MClientSnap.h b/src/messages/MClientSnap.h
index fade84aa24c05adbb921c681eb07e7653dfdf899..d2d0633addbb129c46c5f6bfa034c91e94461e3c 100644 (file)
--- a/src/messages/MClientSnap.h
+++ b/src/messages/MClientSnap.h
@@ -67,7 +67,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MDentryLink.h b/src/messages/MDentryLink.h
index 803172fa81659b0a0de4455f9be185efdbd7603f..f96dccf96bb6acc4dd397687826c83fa490a1d00 100644 (file)
--- a/src/messages/MDentryLink.h
+++ b/src/messages/MDentryLink.h
@@ -76,7 +76,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MDentryUnlink.h b/src/messages/MDentryUnlink.h
index 2925f52ec4212ca30e57b208e5381f19d1be49b0..210fa033c5219219616129d053795862df0b5768 100644 (file)
--- a/src/messages/MDentryUnlink.h
+++ b/src/messages/MDentryUnlink.h
@@ -67,7 +67,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MDirUpdate.h b/src/messages/MDirUpdate.h
index df1d2c686f775f2e871435eb5b216bde85f1df77..67b4e1f3b5611cf7c3d8e8dde3e164fc6cbf6026 100644 (file)
--- a/src/messages/MDirUpdate.h
+++ b/src/messages/MDirUpdate.h
@@ -94,7 +94,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MDiscover.h b/src/messages/MDiscover.h
index 44536bcd2ff5aa2591f3c83539386e340fa9811c..5a69fa7fa24fca52c77e11aa49423969f1e38195 100644 (file)
--- a/src/messages/MDiscover.h
+++ b/src/messages/MDiscover.h
@@ -96,7 +96,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MDiscoverReply.h b/src/messages/MDiscoverReply.h
index 2de4592582aab755cc2718bdae759a145ad6efa4..e8a553f1d8ea3c7c19b1332253050c22951002bb 100644 (file)
--- a/src/messages/MDiscoverReply.h
+++ b/src/messages/MDiscoverReply.h
@@ -211,7 +211,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MExportCaps.h b/src/messages/MExportCaps.h
index 01220dcba5350296ad13d70b845cb433721c2c61..86c795403c7b6c1539889ef57639ea8da6852893 100644 (file)
--- a/src/messages/MExportCaps.h
+++ b/src/messages/MExportCaps.h
@@ -60,7 +60,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MExportCapsAck.h b/src/messages/MExportCapsAck.h
index 83a766525c284ec58df0554d52ce7bac6fa228c5..d575881924f9f35bba90689a77fe974a5857d610 100644 (file)
--- a/src/messages/MExportCapsAck.h
+++ b/src/messages/MExportCapsAck.h
@@ -54,7 +54,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MExportDir.h b/src/messages/MExportDir.h
index 643fc5002ad53a170ad51bd52f0188ae22c047cc..7c2b39166a7e9e2e15f2909f063c100b02257c18 100644 (file)
--- a/src/messages/MExportDir.h
+++ b/src/messages/MExportDir.h
@@ -62,7 +62,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MExportDirAck.h b/src/messages/MExportDirAck.h
index be9c8c4cb29399e203da956fefc3131f5dda0810..76b872df46652f6bdc3e3b4a969723acc93d8830 100644 (file)
--- a/src/messages/MExportDirAck.h
+++ b/src/messages/MExportDirAck.h
@@ -54,7 +54,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MExportDirCancel.h b/src/messages/MExportDirCancel.h
index b5ab08b0d0d0140e1f1e48ada84c4402b30145a8..b085231e7950a2f3f37571357725a1b9ac083c94 100644 (file)
--- a/src/messages/MExportDirCancel.h
+++ b/src/messages/MExportDirCancel.h
@@ -54,7 +54,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MExportDirDiscover.h b/src/messages/MExportDirDiscover.h
index 8108ebfd2daa31a45192f7b70fbc7c19001a63a0..c191e1011d526c19ea9564d27e034a9d99f52185 100644 (file)
--- a/src/messages/MExportDirDiscover.h
+++ b/src/messages/MExportDirDiscover.h
@@ -69,7 +69,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MExportDirDiscoverAck.h b/src/messages/MExportDirDiscoverAck.h
index 78de063acd438ad2a5dc85139b001c0c2773562b..3d7870b22a66797810b94537d516d981e019b664 100644 (file)
--- a/src/messages/MExportDirDiscoverAck.h
+++ b/src/messages/MExportDirDiscoverAck.h
@@ -65,7 +65,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MExportDirFinish.h b/src/messages/MExportDirFinish.h
index eec90def3fab8f26fd96427d73216bd7eff011dd..f691301495738cedd798467d58118ec5881c9cb2 100644 (file)
--- a/src/messages/MExportDirFinish.h
+++ b/src/messages/MExportDirFinish.h
@@ -59,7 +59,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MExportDirNotify.h b/src/messages/MExportDirNotify.h
index 4e458e27b0d04d8c301f0592868c3de26b1ed6ee..d6f0f4e7723a995af7648e4ed2f33643fd25fbba 100644 (file)
--- a/src/messages/MExportDirNotify.h
+++ b/src/messages/MExportDirNotify.h
@@ -86,7 +86,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MExportDirNotifyAck.h b/src/messages/MExportDirNotifyAck.h
index 2f7631221dc33bf8d2875cd38b06b2e2567861a7..0dd3f46b2bd49d010c82e449089e34abc4b5e318 100644 (file)
--- a/src/messages/MExportDirNotifyAck.h
+++ b/src/messages/MExportDirNotifyAck.h
@@ -59,7 +59,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MExportDirPrep.h b/src/messages/MExportDirPrep.h
index ab2d0c568e244ec9a349b8f610a23afce0c47410..0927ff9f5a59f50e4fa33b38af400370af610fcf 100644 (file)
--- a/src/messages/MExportDirPrep.h
+++ b/src/messages/MExportDirPrep.h
@@ -89,7 +89,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MExportDirPrepAck.h b/src/messages/MExportDirPrepAck.h
index d557934bee8fd756ab76281d2e5341040d62e6f1..b51182d45e5641c4994b6fb7067a111b12fdb497 100644 (file)
--- a/src/messages/MExportDirPrepAck.h
+++ b/src/messages/MExportDirPrepAck.h
@@ -60,7 +60,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MGatherCaps.h b/src/messages/MGatherCaps.h
index 49648fb67293923b71fc8f2a8f59fd0ae77a7f53..35ae7fdcd20b4eb716fb12195e119beaed746d08 100644 (file)
--- a/src/messages/MGatherCaps.h
+++ b/src/messages/MGatherCaps.h
@@ -35,7 +35,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MHeartbeat.h b/src/messages/MHeartbeat.h
index b09f2dc3ac72b62089d942f45a2a723954a02544..3889b30651a7b93d5983cb9ddca00d8ef7ca7acb 100644 (file)
--- a/src/messages/MHeartbeat.h
+++ b/src/messages/MHeartbeat.h
@@ -62,7 +62,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MInodeFileCaps.h b/src/messages/MInodeFileCaps.h
index 365e3da3fb6e41b9b75137707e71478eeec2353c..f8fc6fce651aef4d1ba90a366f58b67d82a274f3 100644 (file)
--- a/src/messages/MInodeFileCaps.h
+++ b/src/messages/MInodeFileCaps.h
@@ -59,7 +59,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MLock.h b/src/messages/MLock.h
index 134d67a8a717460c448bbdac8772e50e283fe1d9..7eb5ec098c4ef01f570c601533fafdb3ac0c1c7f 100644 (file)
--- a/src/messages/MLock.h
+++ b/src/messages/MLock.h
@@ -102,7 +102,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSBeacon.h b/src/messages/MMDSBeacon.h
index 7cea31ee05d8d49b1c76b098ae9b684f66a82f87..82a310d1eee36270ee7626441379c20fa4be1fa9 100644 (file)
--- a/src/messages/MMDSBeacon.h
+++ b/src/messages/MMDSBeacon.h
@@ -318,7 +318,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSCacheRejoin.h b/src/messages/MMDSCacheRejoin.h
index 282d01dda762a5a5aeaefb7fe69f24689228d320..a9211d53538ad8e07ef7e7146da7195fe52d4d19 100644 (file)
--- a/src/messages/MMDSCacheRejoin.h
+++ b/src/messages/MMDSCacheRejoin.h
@@ -344,7 +344,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 
   static constexpr int HEAD_VERSION = 2;
   static constexpr int COMPAT_VERSION = 1;

diff --git a/src/messages/MMDSFindIno.h b/src/messages/MMDSFindIno.h
index 0096eab6536c137e86e6f53df332d4b7424cae06..a729296da8e96717ab71bb69e1220ece54e812c4 100644 (file)
--- a/src/messages/MMDSFindIno.h
+++ b/src/messages/MMDSFindIno.h
@@ -51,7 +51,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSFindInoReply.h b/src/messages/MMDSFindInoReply.h
index a814222d528fcc57bd02a0ae4e805a3b1df21daa..274567f0cf4f703671a2816bd47c38711ea2d134 100644 (file)
--- a/src/messages/MMDSFindInoReply.h
+++ b/src/messages/MMDSFindInoReply.h
@@ -51,7 +51,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSFragmentNotify.h b/src/messages/MMDSFragmentNotify.h
index 1148ce6f918e7aeed36f26d343b1be6a0769bba5..2bc2ea629deb08ee99e15da89cc154aa0835d0c5 100644 (file)
--- a/src/messages/MMDSFragmentNotify.h
+++ b/src/messages/MMDSFragmentNotify.h
@@ -72,7 +72,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);  
+  friend MURef<T> crimson::make_message(Args&&... args);  
 };
 
 #endif

diff --git a/src/messages/MMDSFragmentNotifyAck.h b/src/messages/MMDSFragmentNotifyAck.h
index 13564cf98378bfeb2f6813cdaa0304fbf536fdb2..ca22183cf68b22d65c6fbb734d779e06111698ca 100644 (file)
--- a/src/messages/MMDSFragmentNotifyAck.h
+++ b/src/messages/MMDSFragmentNotifyAck.h
@@ -58,7 +58,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSLoadTargets.h b/src/messages/MMDSLoadTargets.h
index 91dc86d11e1cb3df8a2e0345d03e8ea1fb24b1b9..ebd96bff1c62d366a02e57ca0d29afdaf352c9dd 100644 (file)
--- a/src/messages/MMDSLoadTargets.h
+++ b/src/messages/MMDSLoadTargets.h
@@ -59,7 +59,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSMap.h b/src/messages/MMDSMap.h
index 3404f8c1fdef0b66ef61b4e3469c8ac024546aeb..9ea18131127a617b5ee88bc142b8d810e10df4b9 100644 (file)
--- a/src/messages/MMDSMap.h
+++ b/src/messages/MMDSMap.h
@@ -85,7 +85,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSMetrics.h b/src/messages/MMDSMetrics.h
index beafd92875fd21c68a02821a1d3252410bea2625..4812e89bc30769e5d2ffe69547e61715a752efc4 100644 (file)
--- a/src/messages/MMDSMetrics.h
+++ b/src/messages/MMDSMetrics.h
@@ -49,7 +49,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif // CEPH_MDS_METRICS_H

diff --git a/src/messages/MMDSOpenIno.h b/src/messages/MMDSOpenIno.h
index 047b6ba78c438f45edde318c6f818864e85ed968..842ebe1e5cc86008335c7914f7b854a8fc0e9c1b 100644 (file)
--- a/src/messages/MMDSOpenIno.h
+++ b/src/messages/MMDSOpenIno.h
@@ -55,7 +55,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSOpenInoReply.h b/src/messages/MMDSOpenInoReply.h
index 714a55d92d3fa34def2737c3cd93c2a58c5315e0..25a2ea27956cebaab2a1a3efa6a1d09d8934d4bb 100644 (file)
--- a/src/messages/MMDSOpenInoReply.h
+++ b/src/messages/MMDSOpenInoReply.h
@@ -60,7 +60,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSPeerRequest.h b/src/messages/MMDSPeerRequest.h
index 4c74c28d5dfe0028e53570d08a5463dd25fd9d6c..1799ab361a11587cac19e4d0c2c4bb40a06d1bb6 100644 (file)
--- a/src/messages/MMDSPeerRequest.h
+++ b/src/messages/MMDSPeerRequest.h
@@ -229,7 +229,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSPing.h b/src/messages/MMDSPing.h
index 992c856d92e954369aa5d230899cdc11498de6b3..cf209baf69e7d18b54fce3caab08764d43d8e036 100644 (file)
--- a/src/messages/MMDSPing.h
+++ b/src/messages/MMDSPing.h
@@ -46,7 +46,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif // CEPH_MESSAGES_MMDSPING_H

diff --git a/src/messages/MMDSResolve.h b/src/messages/MMDSResolve.h
index c403e9b8e70ad38bef45d5b41833b890d00e0dc9..6a6ff2771db718f3c42814dd7a3e6da8b3ecf111 100644 (file)
--- a/src/messages/MMDSResolve.h
+++ b/src/messages/MMDSResolve.h
@@ -149,7 +149,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 inline std::ostream& operator<<(std::ostream& out, const MMDSResolve::peer_request&) {

diff --git a/src/messages/MMDSResolveAck.h b/src/messages/MMDSResolveAck.h
index 7bc9f20095e25c333915c02ab8ebaa6a66d4aaab..0b459aaef9cfc9c00df348441e7881f4221aeb74 100644 (file)
--- a/src/messages/MMDSResolveAck.h
+++ b/src/messages/MMDSResolveAck.h
@@ -61,7 +61,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSScrub.h b/src/messages/MMDSScrub.h
index 5e05e213b2d3bb1718cecb2445d03a615cccd302..a1bf2b54f5dd07a7e7ef016d97f1a92fe08cb608 100644 (file)
--- a/src/messages/MMDSScrub.h
+++ b/src/messages/MMDSScrub.h
@@ -123,7 +123,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 
   static constexpr unsigned FLAG_INTERNAL_TAG  = 1<<0;
   static constexpr unsigned FLAG_FORCE         = 1<<1;

diff --git a/src/messages/MMDSScrubStats.h b/src/messages/MMDSScrubStats.h
index 5f3700745c3d8362484e15b05a02529dcb3a57ae..ab4268ec52b81cd0e381f9e0d145f3088853f84c 100644 (file)
--- a/src/messages/MMDSScrubStats.h
+++ b/src/messages/MMDSScrubStats.h
@@ -76,7 +76,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSSnapUpdate.h b/src/messages/MMDSSnapUpdate.h
index f3ea8103f807df5ea66bcdccd5f5268c02a19a79..91ff42c42b693dec9a818b757bdf584758d87f80 100644 (file)
--- a/src/messages/MMDSSnapUpdate.h
+++ b/src/messages/MMDSSnapUpdate.h
@@ -59,7 +59,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMDSTableRequest.h b/src/messages/MMDSTableRequest.h
index b82d9813b27b5bbe03bad9b2e7a66143278d25d5..df7722f219a683aa17cdfc176e5c5c688135dfd2 100644 (file)
--- a/src/messages/MMDSTableRequest.h
+++ b/src/messages/MMDSTableRequest.h
@@ -66,7 +66,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMgrConfigure.h b/src/messages/MMgrConfigure.h
index 368e689c065b3f7524975f9459d4a6c76aa6c277..ab3a41e3713c9947386a122407b32a5c046e6d79 100644 (file)
--- a/src/messages/MMgrConfigure.h
+++ b/src/messages/MMgrConfigure.h
@@ -82,7 +82,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMgrDigest.h b/src/messages/MMgrDigest.h
index 3ab32daaf2011e739faa6ff74671479917bc63ba..e9c4b45f62658419447838f3428d8ba1317f4dae 100644 (file)
--- a/src/messages/MMgrDigest.h
+++ b/src/messages/MMgrDigest.h
@@ -54,7 +54,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMgrMap.h b/src/messages/MMgrMap.h
index ed5230fe0bd6037fbd73a4d2859178262f04f02a..2026fa3a4b46fa4ddd18a392904a43af5a46fb22 100644 (file)
--- a/src/messages/MMgrMap.h
+++ b/src/messages/MMgrMap.h
@@ -54,7 +54,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMgrOpen.h b/src/messages/MMgrOpen.h
index 8142f5be6e1249c39abf3e65de50c906f3bfbd04..9c9345e8ab47ba2cb4df898618d25bdebb1a4bff 100644 (file)
--- a/src/messages/MMgrOpen.h
+++ b/src/messages/MMgrOpen.h
@@ -93,7 +93,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MMgrReport.h b/src/messages/MMgrReport.h
index 3ab1bcdbe1897ecbe9a3e6cd1e905f8488e97ed2..bd3c221a847eac41e01304655c3711419ed23f8f 100644 (file)
--- a/src/messages/MMgrReport.h
+++ b/src/messages/MMgrReport.h
@@ -198,7 +198,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/messages/MRemoveSnaps.h b/src/messages/MRemoveSnaps.h
index 66ce359b705aa8ea77f4858305e312058dfecb99..a735b2a9d19f92e4de9d68d031affa57b37acc42 100644 (file)
--- a/src/messages/MRemoveSnaps.h
+++ b/src/messages/MRemoveSnaps.h
@@ -52,7 +52,7 @@ private:
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
   template<class T, typename... Args>
-  friend MURef<T> crimson::net::make_message(Args&&... args);
+  friend MURef<T> crimson::make_message(Args&&... args);
 };
 
 #endif

diff --git a/src/msg/Message.h b/src/msg/Message.h
index c427a222e2f8c9be9c0bd1392963bbdffa24a1e0..362ae5ec6089d9c8eeb988aeced8b375ea5a248e 100644 (file)
--- a/src/msg/Message.h
+++ b/src/msg/Message.h
@@ -553,7 +553,7 @@ ceph::ref_t<T> make_message(Args&&... args) {
 }
 }
 
-namespace crimson::net {
+namespace crimson {
 template<class T, typename... Args>
 MURef<T> make_message(Args&&... args) {
   return {new T(std::forward<Args>(args)...), TOPNSPC::common::UniquePtrDeleter{}};

diff --git a/src/osd/PeeringState.cc b/src/osd/PeeringState.cc
index a1e59c4bcd72e10165e11e8a9d7ce9fde765ee7e..fbbac6b6697778f10c01fbfa0b8abc2bcf2adcc1 100644 (file)
--- a/src/osd/PeeringState.cc
+++ b/src/osd/PeeringState.cc
@@ -257,10 +257,10 @@ void PeeringState::purge_strays()
       psdout(10) << "sending PGRemove to osd." << *p << dendl;
       vector<spg_t> to_remove;
       to_remove.push_back(spg_t(info.pgid.pgid, p->shard));
-      auto m = make_message<MOSDPGRemove>(
+      auto m = TOPNSPC::make_message<MOSDPGRemove>(
        get_osdmap_epoch(),
        to_remove);
-      pl->send_cluster_message(p->osd, m, get_osdmap_epoch());
+      pl->send_cluster_message(p->osd, std::move(m), get_osdmap_epoch());
     } else {
       psdout(10) << "not sending PGRemove to down osd." << *p << dendl;
     }
@@ -1134,7 +1134,7 @@ void PeeringState::send_lease()
     }
     pl->send_cluster_message(
       peer.osd,
-      make_message<MOSDPGLease>(epoch,
+      TOPNSPC::make_message<MOSDPGLease>(epoch,
                      spg_t(spgid.pgid, peer.shard),
                      get_lease()),
       epoch);
@@ -1423,7 +1423,7 @@ void PeeringState::reject_reservation()
   pl->unreserve_recovery_space();
   pl->send_cluster_message(
     primary.osd,
-    make_message<MBackfillReserve>(
+    TOPNSPC::make_message<MBackfillReserve>(
       MBackfillReserve::REJECT_TOOFULL,
       spg_t(info.pgid.pgid, primary.shard),
       get_osdmap_epoch()),
@@ -2718,7 +2718,11 @@ void PeeringState::activate(
 
       psdout(10) << "activate peer osd." << peer << " " << pi << dendl;
 
+      #if defined(WITH_SEASTAR)
+      MURef<MOSDPGLog> m;
+      #else
       MRef<MOSDPGLog> m;
+      #endif
       ceph_assert(peer_missing.count(peer));
       pg_missing_t& pm = peer_missing[peer];
 
@@ -2745,7 +2749,7 @@ void PeeringState::activate(
        } else {
          psdout(10) << "activate peer osd." << peer
                     << " is up to date, but sending pg_log anyway" << dendl;
-         m = make_message<MOSDPGLog>(
+         m = TOPNSPC::make_message<MOSDPGLog>(
            i->shard, pg_whoami.shard,
            get_osdmap_epoch(), info,
            last_peering_reset);
@@ -2782,7 +2786,7 @@ void PeeringState::activate(
        // initialize peer with our purged_snaps.
        pi.purged_snaps = info.purged_snaps;
 
-       m = make_message<MOSDPGLog>(
+       m = TOPNSPC::make_message<MOSDPGLog>(
          i->shard, pg_whoami.shard,
          get_osdmap_epoch(), pi,
          last_peering_reset /* epoch to create pg at */);
@@ -2797,7 +2801,7 @@ void PeeringState::activate(
       } else {
        // catch up
        ceph_assert(pg_log.get_tail() <= pi.last_update);
-       m = make_message<MOSDPGLog>(
+       m = TOPNSPC::make_message<MOSDPGLog>(
          i->shard, pg_whoami.shard,
          get_osdmap_epoch(), info,
          last_peering_reset /* epoch to create pg at */);
@@ -2829,7 +2833,7 @@ void PeeringState::activate(
        dout(10) << "activate peer osd." << peer << " sending " << m->log
                 << dendl;
        m->lease = get_lease();
-       pl->send_cluster_message(peer.osd, m, get_osdmap_epoch());
+       pl->send_cluster_message(peer.osd, std::move(m), get_osdmap_epoch());
       }
 
       // peer now has
@@ -2944,13 +2948,13 @@ void PeeringState::share_pg_info()
       peer->second.last_interval_started = info.last_interval_started;
       peer->second.history.merge(info.history);
     }
-    MessageRef m = make_message<MOSDPGInfo2>(spg_t{info.pgid.pgid, pg_shard.shard},
+    auto m = TOPNSPC::make_message<MOSDPGInfo2>(spg_t{info.pgid.pgid, pg_shard.shard},
                          info,
                          get_osdmap_epoch(),
                          get_osdmap_epoch(),
                          std::optional<pg_lease_t>{get_lease()},
                          std::nullopt);
-    pl->send_cluster_message(pg_shard.osd, m, get_osdmap_epoch());
+    pl->send_cluster_message(pg_shard.osd, std::move(m), get_osdmap_epoch());
   }
 }
 
@@ -3075,7 +3079,7 @@ void PeeringState::fulfill_log(
   ceph_assert(from == primary);
   ceph_assert(query.type != pg_query_t::INFO);
 
-  auto mlog = make_message<MOSDPGLog>(
+  auto mlog = TOPNSPC::make_message<MOSDPGLog>(
     from.shard, pg_whoami.shard,
     get_osdmap_epoch(),
     info, query_epoch);
@@ -3101,7 +3105,7 @@ void PeeringState::fulfill_log(
 
   psdout(10) << " sending " << mlog->log << " " << mlog->missing << dendl;
 
-  pl->send_cluster_message(from.osd, mlog, get_osdmap_epoch(), true);
+  pl->send_cluster_message(from.osd, std::move(mlog), get_osdmap_epoch(), true);
 }
 
 void PeeringState::fulfill_query(const MQuery& query, PeeringCtxWrapper &rctx)
@@ -4321,7 +4325,7 @@ void PeeringState::recovery_committed_to(eversion_t version)
       // we are fully up to date.  tell the primary!
       pl->send_cluster_message(
        get_primary().osd,
-       make_message<MOSDPGTrim>(
+       TOPNSPC::make_message<MOSDPGTrim>(
          get_osdmap_epoch(),
          spg_t(info.pgid.pgid, primary.shard),
          last_complete_ondisk),
@@ -4964,7 +4968,7 @@ void PeeringState::Backfilling::backfill_release_reservations()
     ceph_assert(*it != ps->pg_whoami);
     pl->send_cluster_message(
       it->osd,
-      make_message<MBackfillReserve>(
+      TOPNSPC::make_message<MBackfillReserve>(
        MBackfillReserve::RELEASE,
        spg_t(ps->info.pgid.pgid, it->shard),
        ps->get_osdmap_epoch()),
@@ -5088,7 +5092,7 @@ PeeringState::WaitRemoteBackfillReserved::react(const RemoteBackfillReserved &ev
     ceph_assert(*backfill_osd_it != ps->pg_whoami);
     pl->send_cluster_message(
       backfill_osd_it->osd,
-      make_message<MBackfillReserve>(
+      TOPNSPC::make_message<MBackfillReserve>(
        MBackfillReserve::REQUEST,
        spg_t(context< PeeringMachine >().spgid.pgid, backfill_osd_it->shard),
        ps->get_osdmap_epoch(),
@@ -5128,7 +5132,7 @@ void PeeringState::WaitRemoteBackfillReserved::retry()
     ceph_assert(*it != ps->pg_whoami);
     pl->send_cluster_message(
       it->osd,
-      make_message<MBackfillReserve>(
+      TOPNSPC::make_message<MBackfillReserve>(
        MBackfillReserve::RELEASE,
        spg_t(context< PeeringMachine >().spgid.pgid, it->shard),
        ps->get_osdmap_epoch()),
@@ -5301,7 +5305,7 @@ PeeringState::RepWaitRecoveryReserved::react(const RemoteRecoveryReserved &evt)
   DECLARE_LOCALS;
   pl->send_cluster_message(
     ps->primary.osd,
-    make_message<MRecoveryReserve>(
+    TOPNSPC::make_message<MRecoveryReserve>(
       MRecoveryReserve::GRANT,
       spg_t(ps->info.pgid.pgid, ps->primary.shard),
       ps->get_osdmap_epoch()),
@@ -5409,7 +5413,7 @@ PeeringState::RepWaitBackfillReserved::react(const RemoteBackfillReserved &evt)
 
   pl->send_cluster_message(
       ps->primary.osd,
-      make_message<MBackfillReserve>(
+      TOPNSPC::make_message<MBackfillReserve>(
        MBackfillReserve::GRANT,
        spg_t(ps->info.pgid.pgid, ps->primary.shard),
        ps->get_osdmap_epoch()),
@@ -5466,7 +5470,7 @@ PeeringState::RepRecovering::react(const RemoteRecoveryPreempted &)
   pl->unreserve_recovery_space();
   pl->send_cluster_message(
     ps->primary.osd,
-    make_message<MRecoveryReserve>(
+    TOPNSPC::make_message<MRecoveryReserve>(
       MRecoveryReserve::REVOKE,
       spg_t(ps->info.pgid.pgid, ps->primary.shard),
       ps->get_osdmap_epoch()),
@@ -5483,7 +5487,7 @@ PeeringState::RepRecovering::react(const BackfillTooFull &)
   pl->unreserve_recovery_space();
   pl->send_cluster_message(
     ps->primary.osd,
-    make_message<MBackfillReserve>(
+    TOPNSPC::make_message<MBackfillReserve>(
       MBackfillReserve::REVOKE_TOOFULL,
       spg_t(ps->info.pgid.pgid, ps->primary.shard),
       ps->get_osdmap_epoch()),
@@ -5500,7 +5504,7 @@ PeeringState::RepRecovering::react(const RemoteBackfillPreempted &)
   pl->unreserve_recovery_space();
   pl->send_cluster_message(
     ps->primary.osd,
-    make_message<MBackfillReserve>(
+    TOPNSPC::make_message<MBackfillReserve>(
       MBackfillReserve::REVOKE,
       spg_t(ps->info.pgid.pgid, ps->primary.shard),
       ps->get_osdmap_epoch()),
@@ -5604,7 +5608,7 @@ PeeringState::WaitRemoteRecoveryReserved::react(const RemoteRecoveryReserved &ev
     ceph_assert(*remote_recovery_reservation_it != ps->pg_whoami);
     pl->send_cluster_message(
       remote_recovery_reservation_it->osd,
-      make_message<MRecoveryReserve>(
+      TOPNSPC::make_message<MRecoveryReserve>(
        MRecoveryReserve::REQUEST,
        spg_t(context< PeeringMachine >().spgid.pgid,
              remote_recovery_reservation_it->shard),
@@ -5654,7 +5658,7 @@ void PeeringState::Recovering::release_reservations(bool cancel)
       continue;
     pl->send_cluster_message(
       i->osd,
-      make_message<MRecoveryReserve>(
+      TOPNSPC::make_message<MRecoveryReserve>(
        MRecoveryReserve::RELEASE,
        spg_t(ps->info.pgid.pgid, i->shard),
        ps->get_osdmap_epoch()),
@@ -6352,7 +6356,7 @@ boost::statechart::result PeeringState::ReplicaActive::react(const MLease& l)
   ps->proc_lease(l.lease);
   pl->send_cluster_message(
     ps->get_primary().osd,
-    make_message<MOSDPGLeaseAck>(epoch,
+    TOPNSPC::make_message<MOSDPGLeaseAck>(epoch,
                       spg_t(spgid.pgid, ps->get_primary().shard),
                       ps->get_lease_ack()),
     epoch);