]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
osd: update sprintf() to snprintf() 7812/head
authorxiexingguo <xie.xingguo@zte.com.cn>
Fri, 26 Feb 2016 11:35:55 +0000 (19:35 +0800)
committerxie xingguo <xie.xingguo@zte.com.cn>
Sat, 27 Feb 2016 13:28:09 +0000 (21:28 +0800)
Which is safer. Also enlarge length of name to 32, which shall be
big enough to hold a int64_t value.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
src/osd/OSDMap.cc

index 9a01c1b21977843039d26cb42a0515a318dab0e6..855d33075e924b8ccee25ba5b2fbd0d8f04d4ea8 100644 (file)
@@ -2771,8 +2771,8 @@ int OSDMap::build_simple_crush_map(CephContext *cct, CrushWrapper& crush,
     loc["rack"] = "localrack";
     loc["root"] = "default";
     ldout(cct, 10) << " adding osd." << o << " at " << loc << dendl;
-    char name[8];
-    sprintf(name, "osd.%d", o);
+    char name[32];
+    snprintf(name, sizeof(name), "osd.%d", o);
     crush.insert_item(cct, o, 1.0, name, loc);
   }