common/cmdparse: do not create temp string for cmd_getval()

cmd_getval() consumes string_view, so no need to create a temporary
std::string instance for it.

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/common/cmdparse.cc b/src/common/cmdparse.cc
index d02a2b99bbd11913f485cb04e9d513ebe2977d76..90da6afef90deeea0b963d94078b8d9e5b72d6fd 100644 (file)
--- a/src/common/cmdparse.cc
+++ b/src/common/cmdparse.cc
@@ -578,7 +578,7 @@ bool validate_bool(CephContext *cct,
 {
   bool v;
   try {
-    if (!cmd_getval(cmdmap, string(name), v)) {
+    if (!cmd_getval(cmdmap, name, v)) {
       if (auto req = desc.find("req");
          req != end(desc) && req->second == "false") {
        return true;
@@ -607,7 +607,7 @@ bool validate_arg(CephContext* cct,
 {
   Value v;
   try {
-    if (!cmd_getval(cmdmap, string(name), v)) {
+    if (!cmd_getval(cmdmap, name, v)) {
       if constexpr (is_vector) {
          // an empty list is acceptable.
          return true;