]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/prometheus: removing call the verify_tls_files
authorRedouane Kachach <rkachach@ibm.com>
Tue, 10 Jun 2025 09:02:05 +0000 (11:02 +0200)
committerSunnatillo <sunnat.samadov@est.tech>
Mon, 7 Jul 2025 15:27:02 +0000 (18:27 +0300)
Removing the call to verify_tls_files as in this case case certs files
are generated by cephadm internally and we can trust them. In the
worst case (bad files) the prometheus module will fail to start.

Fixes: https://tracker.ceph.com/issues/71599
Signed-off-by: Redouane Kachach <rkachach@ibm.com>
(cherry picked from commit bda2ad59aa925ab9463e748d075e96f14d070492)

src/pybind/mgr/prometheus/module.py

index d3a7058e054789f1fbfe914402886377cdb439a4..91fc6fa29e07a8704784246cd20fa6a931745055 100644 (file)
@@ -1790,7 +1790,6 @@ class Module(MgrModule, OrchestratorClientMixin):
                      port=server_port, path='/'))
 
     def setup_tls_using_cephadm(self, server_addr: str, server_port: int) -> None:
-        from mgr_util import verify_tls_files
         cmd = {'prefix': 'orch certmgr generate-certificates',
                'module_name': 'prometheus',
                'format': 'json'}
@@ -1810,7 +1809,6 @@ class Module(MgrModule, OrchestratorClientMixin):
         self.key_file.write(cert_key['key'].encode('utf-8'))
         self.key_file.flush()  # pkey_tmp must not be gc'ed
 
-        verify_tls_files(self.cert_file.name, self.key_file.name)
         cert_file_path, key_file_path = self.cert_file.name, self.key_file.name
 
         cherrypy.config.update({