]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard: fix the rbd mirroring configure check 51255/head
authorNizamudeen A <nia@redhat.com>
Thu, 27 Apr 2023 11:24:24 +0000 (16:54 +0530)
committerNizamudeen A <nia@redhat.com>
Thu, 27 Apr 2023 11:24:24 +0000 (16:54 +0530)
In one-way mirroring, the condition we are checking now for configuring
the mirroring will fail because only one cluster needs to have the
mirror daemon present. Thus even if mirroring is successfuly happening
the page won't load. For now relaxing the rule until we find a better
api call to check for the status

Fixes: https://tracker.ceph.com/issues/59573
Signed-off-by: Nizamudeen A <nia@redhat.com>
src/pybind/mgr/dashboard/controllers/rbd_mirroring.py

index 65eb0b56e8ba5bd55dcd696582625beb02e263bc..2ee53fc1ad46efe5a8479688dd3ba00f2bb41eb9 100644 (file)
@@ -649,7 +649,7 @@ class RbdMirroringStatus(BaseController):
         # using dashboard.
         if not orch_status['available']:
             return status
-        if not CephService.get_service_list('rbd-mirror') or not CephService.get_pool_list('rbd'):
+        if not CephService.get_service_list('rbd-mirror') and not CephService.get_pool_list('rbd'):
             status['available'] = False
             status['message'] = 'RBD mirroring is not configured'  # type: ignore
         return status