common/Finisher: call notify_one() instead of notify_all()

As noted in commit cc7ec3e18d1, there is only ever a single `Finisher`
thread, therefore the overhead for `notify_all()` can be eliminated.

Signed-off-by: Max Kellermann <max.kellermann@ionos.com>

diff --git a/src/common/Finisher.cc b/src/common/Finisher.cc
index 20b8829d7ecdde200f72c6a25c731f6acbbbe92e..8f2262235e89bb6172e00319610a7c74304a4c29 100644 (file)
--- a/src/common/Finisher.cc
+++ b/src/common/Finisher.cc
@@ -20,7 +20,7 @@ void Finisher::stop()
   finisher_stop = true;
   // we don't have any new work to do, but we want the worker to wake up anyway
   // to process the stop condition.
-  finisher_cond.notify_all();
+  finisher_cond.notify_one();
   finisher_lock.unlock();
   finisher_thread.join(); // wait until the worker exits completely
   ldout(cct, 10) << __func__ << " finish" << dendl;

diff --git a/src/common/Finisher.h b/src/common/Finisher.h
index 732ed746d56c40d8150f9a37162a104f9dfd9329..6618749b598e9094831550054371a03b2f4e2c68 100644 (file)
--- a/src/common/Finisher.h
+++ b/src/common/Finisher.h
@@ -88,7 +88,7 @@ class Finisher {
        finisher_queue.push_back(std::make_pair(i, 0));
       }
       if (should_notify) {
-       finisher_cond.notify_all();
+       finisher_cond.notify_one();
       }
     }
     if (logger)