rgw: don't create connection object for zone without endpoints

warn about it though

Signed-off-by: Yehuda Sadeh <yehuda@redhat.com>

diff --git a/src/rgw/rgw_rados.cc b/src/rgw/rgw_rados.cc
index d5772435e3901b330bd586eada26bcf377c7328b..1f3e1cc509e1d3e6fe577d55d47aaa482337a81a 100644 (file)
--- a/src/rgw/rgw_rados.cc
+++ b/src/rgw/rgw_rados.cc
@@ -2721,8 +2721,12 @@ int RGWRados::init_complete()
     const string& id = ziter->first;
     RGWZone& z = ziter->second;
     if (id != zone.get_id()) {
-      ldout(cct, 20) << "generating connection object for zone " << zone.get_name() << " id" << id << dendl;
-      zone_conn_map[id] = new RGWRESTConn(cct, this, z.endpoints);
+      if (!z.endpoints.empty()) {
+        ldout(cct, 20) << "generating connection object for zone " << zone.get_name() << " id " << zone.get_id() << dendl;
+        zone_conn_map[id] = new RGWRESTConn(cct, this, z.endpoints);
+      } else {
+        ldout(cct, 0) << "WARNING: can't generate connection for zone " << zone.get_name() << " id " << zone.get_id() << ": no endpoints defined" << dendl;
+      }
     } else {
       zone_public_config = z;
     }