mgr/smb: improve error handling for generic exceptions

Ensure that something gets added to the error response even if the
caught exception has no associated text.

Signed-off-by: John Mulligan <jmulligan@redhat.com>

diff --git a/src/pybind/mgr/smb/handler.py b/src/pybind/mgr/smb/handler.py
index d6edc30d20595c350e861c9891b99a4f1858c05e..f9cfae7723ae704fd6189fd51311960d90f148b7 100644 (file)
--- a/src/pybind/mgr/smb/handler.py
+++ b/src/pybind/mgr/smb/handler.py
@@ -369,7 +369,11 @@ class ClusterConfigHandler:
             results.append(err)
         except Exception as err:
             log.exception("error updating resource")
-            result = ErrorResult(resource, msg=str(err))
+            msg = str(err)
+            if not msg:
+                # handle the case where the exception has no text
+                msg = f"error updating resource: {type(err)} (see logs for details)"
+            result = ErrorResult(resource, msg=msg)
             results.append(result)
         if results.success:
             log.debug(