]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
test: fix negative blocklist tests
authorGreg Farnum <gfarnum@redhat.com>
Wed, 1 Dec 2021 16:16:18 +0000 (16:16 +0000)
committerGreg Farnum <gfarnum@redhat.com>
Tue, 31 May 2022 23:18:17 +0000 (23:18 +0000)
These tests are supposed to be validating we don't accept invalid IPs,
but they left out the "add" subcommand so they're all failing on that!

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
(cherry picked from commit 824689217248128cec67317d1410624fd94d276c)

qa/workunits/cephtool/test.sh

index 1b4af176693b6c9d419b0324df616b5e70e2eceb..73e0836fc744f1ca4b3d6613f1b4f3b5f42beec9 100755 (executable)
@@ -1426,11 +1426,11 @@ function test_mon_osd()
   ceph osd blocklist ls | grep $bl
   ceph osd blocklist rm $bl
   ceph osd blocklist ls | expect_false grep $bl
-  expect_false "ceph osd blocklist $bl/-1"
-  expect_false "ceph osd blocklist $bl/foo"
+  expect_false "ceph osd blocklist add $bl/-1"
+  expect_false "ceph osd blocklist add $bl/foo"
 
-  # test with wrong address
-  expect_false "ceph osd blocklist 1234.56.78.90/100"
+  # test with invalid address
+  expect_false "ceph osd blocklist add 1234.56.78.90/100"
 
   # Test `clear`
   ceph osd blocklist add $bl