]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
osd/OSD.cc: remove osd_lock for bench 36664/head
authorNeha Ojha <nojha@redhat.com>
Fri, 17 Jul 2020 16:52:56 +0000 (16:52 +0000)
committerNathan Cutler <ncutler@suse.com>
Sat, 15 Aug 2020 13:29:50 +0000 (15:29 +0200)
8987f94416f453829eae6dda08837ef5a42531c6 introduced the osd_lock for the
bench command. Taking the osd_lock in bench can lead to deadlocks, causing the
command to hang as seen in https://tracker.ceph.com/issues/43888.

Fixes: https://tracker.ceph.com/issues/43888
Signed-off-by: Adam Kupczyk <akupczyk@redhat.com>
Signed-off-by: Neha Ojha <nojha@redhat.com>
(cherry picked from commit d6be0d3f9a091b8a2e20ea607434314d395a821c)

src/osd/OSD.cc

index 4e46511885f0d545c30bb448fd6105ebd2ccfaf3..7b6e1aca215d448af9bb7df24ac1f6bc60bd1f8c 100644 (file)
@@ -2709,7 +2709,6 @@ will start to track new ops received afterwards.";
   }
 
   else if (prefix == "bench") {
-    lock_guard l(osd_lock);
     int64_t count;
     int64_t bsize;
     int64_t osize, onum;