Merge pull request #26701 from adamemerson/wip-trip-the-light-clangtastic

fix clang build failures, and clean up warnings

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Reviewed-by: Sage Weil <sage@redhat.com>
Reviewed-by: Kefu Chai <kchai@redhat.com>

diff --cc src/mgr/BaseMgrModule.cc
Simple merge

diff --cc src/rgw/rgw_lc.cc
Simple merge

diff --cc src/rgw/rgw_rados.cc
index 1468457a3cb0e604c8437510700db46250a673cd,0c5e9ceba49c9a0b454f724408502121e32c43d0..1bca970f5707dbabe9087f43df63343770a6220c
--- 1/src/rgw/rgw_rados.cc
--- 2/src/rgw/rgw_rados.cc
+++ b/src/rgw/rgw_rados.cc
@@@ -2432,10 -2432,10 +2432,10 @@@ int RGWRados::Bucket::update_bucket_id(
  static inline std::string after_delim(std::string_view delim)
  {
    // assert: ! delim.empty()
-   char e = delim.back();
+   unsigned char e = delim.back();
    delim.remove_suffix(1);
    std::string result{delim.data(), delim.length()};
 -  if (e < 255) {
 +  if (uint8_t(e) < 255) {
      result += char(++e);
    } else {
      result += e;