client: Fixes coverity defect 716891

Fix for coverity defect 716891 [DEADCODE] in
Client::encode_dentry_release where the released var is initialized
to 0, but never set, so the pre-emptive release of the dentry
capability (if requested by the drop flag) never happens.

Signed-off-by: Sam Lang <sam.lang@inktank.com>

diff --git a/src/client/Client.cc b/src/client/Client.cc
index 694ed0a8cff0f93f77a79d3ea49a09d3d4840d1d..80cbee8a05fad6c107893d989564a1b8bbae4988 100644 (file)
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -1165,8 +1165,8 @@ void Client::encode_dentry_release(Dentry *dn, MetaRequest *req,
           << dn << ")" << dendl;
   int released = 0;
   if (dn->dir)
-    encode_inode_release(dn->dir->parent_inode, req,
-                        mds, drop, unless, 1);
+    released = encode_inode_release(dn->dir->parent_inode, req,
+                                   mds, drop, unless, 1);
   if (released && dn->lease_mds == mds) {
     ldout(cct, 25) << "preemptively releasing dn to mds" << dendl;
     MClientRequest::Release& rel = req->cap_releases.back();