// but because we want their pg_info to inform choose_acting(), and
// so that we know what they do/do not have explicitly before
// sending them any new info/logs/whatever.
- for (unsigned i=0; i<acting.size(); i++) {
+ for (unsigned i = 0; i < acting.size(); i++) {
if (acting[i] != CRUSH_ITEM_NONE)
probe.insert(pg_shard_t(acting[i], ec_pool ? shard_id_t(i) : shard_id_t::NO_SHARD));
}
- // It may be possible to exlude the up nodes, but let's keep them in
+ // It may be possible to exclude the up nodes, but let's keep them in
// there for now.
- for (unsigned i=0; i<up.size(); i++) {
+ for (unsigned i = 0; i < up.size(); i++) {
if (up[i] != CRUSH_ITEM_NONE)
probe.insert(pg_shard_t(up[i], ec_pool ? shard_id_t(i) : shard_id_t::NO_SHARD));
}
bool any_down_now = false; // any candidates down now (that might have useful data)
// consider ACTING osds
- for (unsigned i=0; i<interval.acting.size(); i++) {
+ for (unsigned i = 0; i < interval.acting.size(); i++) {
int o = interval.acting[i];
if (o == CRUSH_ITEM_NONE)
continue;
int o = *p;
if (osdmap->is_up(o)) {
- dout(10) << "affected_by_map osd." << *p << " now up" << dendl;
+ dout(10) << "affected_by_map osd." << o << " now up" << dendl;
return true;
}
map<int, epoch_t>::const_iterator r = blocked_by.find(o);
if (r != blocked_by.end()) {
if (osdmap->get_info(o).lost_at != r->second) {
- dout(10) << "affected_by_map osd." << o << " (re)marked as lost" << dendl;
- return true;
+ dout(10) << "affected_by_map osd." << o << " (re)marked as lost" << dendl;
+ return true;
}
}
}
bool ReplicatedPG::is_degraded_or_backfilling_object(const hobject_t& soid)
{
/* The conditions below may clear (on_local_recover, before we queue
- * the tranasction) before we actually requeue the degraded waiters
+ * the transaction) before we actually requeue the degraded waiters
* in on_global_recover after the transaction completes.
*/
if (waiting_for_degraded_object.count(soid))
vector<inode_backpointer_t>::iterator vi;
for (vi = bt.ancestors.begin(); vi != bt.ancestors.end(); ++vi) {
generic_dout(0) << "vi->dirino=" << vi->dirino << " parent_ino=" << parent_ino << dendl;
- if ( vi->dirino == parent_ino) {
+ if (vi->dirino == parent_ino) {
::encode(*vi, outdata);
return true;
}
} else {
// Successfully constructed and initialized, return it.
*pfilter = filter;
- return 0;
+ return 0;
}
}
{
f->open_array_section("objects");
int32_t num = 0;
- bufferlist bl;
for (; p != needs_recovery_map.end() && num < cct->_conf->osd_command_max_records; ++p) {
if (missing_loc.is_unfound(p->first)) {
f->open_object_section("object");
}
f->close_section();
}
- f->dump_int("more", p != needs_recovery_map.end());
+ f->dump_bool("more", p != needs_recovery_map.end());
f->close_section();
f->flush(odata);
return 0;
PGBackend::build_pg_backend(
_pool.info, curmap, this, coll_t(p), ch, o->store, cct)),
object_contexts(o->cct, g_conf->osd_pg_object_context_cache_count),
- snapset_contexts_lock("ReplicatedPG::snapset_contexts"),
+ snapset_contexts_lock("ReplicatedPG::snapset_contexts_lock"),
backfills_in_flight(hobject_t::Comparator(true)),
pending_backfill_updates(hobject_t::Comparator(true)),
new_backfill(false),