]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mds: don't rdlock_try authlock for path_traverse permission check
authorSage Weil <sage@newdream.net>
Thu, 9 Apr 2009 20:26:17 +0000 (13:26 -0700)
committerSage Weil <sage@newdream.net>
Thu, 9 Apr 2009 20:26:17 +0000 (13:26 -0700)
We don't actually check anything anyway, just ping the lock.

If the client is trusted with AUTH_EXCL, this is pointless anyway.
It is only really useful with untrusted (e.g., fuse) clients, but
they'll need some sort of special support for that later.

src/mds/MDCache.cc

index 57d5fd3da7479e552f397dc545f045ac68fc90e4..23c911e596681ca3cb993f6c2c85258082403d02 100644 (file)
@@ -5622,12 +5622,14 @@ int MDCache::path_traverse(MDRequest *mdr, Message *req,     // who
     */
 
     // must read directory hard data (permissions, x bit) to traverse
+#if 0    
     if (!noperm && 
        !mds->locker->rdlock_try(&cur->authlock, client, 0)) {
       dout(7) << "traverse: waiting on authlock rdlock on " << *cur << dendl;
       cur->authlock.add_waiter(SimpleLock::WAIT_RD, _get_waiter(mdr, req));
       return 1;
     }
+#endif
     
     // check permissions?
     // XXX