]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard: fix ssl cert validation for ingress service creation
authorAvan Thakkar <athakkar@redhat.com>
Mon, 2 May 2022 08:02:36 +0000 (13:32 +0530)
committerAvan Thakkar <athakkar@redhat.com>
Mon, 9 May 2022 12:37:36 +0000 (18:07 +0530)
Fixes: https://tracker.ceph.com/issues/55511
Signed-off-by: Avan Thakkar <athakkar@redhat.com>
(cherry picked from commit 0017fa5bc91570e1cf873b59efa3cd1787c49216)

src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.ts

index 22b401ec86a61f85298f59628350474697e80ad2..b76469202745724f38c2da9c4cd6ca60ebe23e05 100644 (file)
           </div>
 
           <!-- ssl_key -->
-          <div *ngIf="serviceForm.controls.ssl.value && serviceForm.controls.service_type.value !== 'rgw'"
+          <div *ngIf="serviceForm.controls.ssl.value && !(['rgw', 'ingress'].includes(serviceForm.controls.service_type.value))"
                class="form-group row">
             <label class="cd-col-form-label"
                    for="ssl_key">
index ac4eec308f87971fdd01218fba95b2564cff78e4..4d964575eec1811aa0ad9a574c0448eec95aad0a 100644 (file)
@@ -199,6 +199,14 @@ export class ServiceFormComponent extends CdForm implements OnInit {
               ssl: true
             },
             [Validators.required, CdValidators.sslCert()]
+          ),
+          CdValidators.composeIf(
+            {
+              service_type: 'ingress',
+              unmanaged: false,
+              ssl: true
+            },
+            [Validators.required, CdValidators.pemCert()]
           )
         ]
       ],