]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard: Fix /api/grafana/validation 25997/head
authorZack Cerza <zack@redhat.com>
Wed, 16 Jan 2019 20:36:23 +0000 (13:36 -0700)
committerZack Cerza <zack@redhat.com>
Wed, 16 Jan 2019 20:36:23 +0000 (13:36 -0700)
If the Grafana URL contains a trailing slash, this endpoint ends up
returning a 404, disabling the integration entirely. Fix that.

Signed-off-by: Zack Cerza <zack@redhat.com>
src/pybind/mgr/dashboard/controllers/grafana.py

index ec444c5fca02ebc04ad26df584560e278b540d64..d165d45259d1eeda803ad9b8bc976e3385accdce 100644 (file)
@@ -32,6 +32,7 @@ class Grafana(BaseController):
     def validation(self, params):
         grafana = GrafanaRestClient()
         method = 'GET'
-        url = Settings.GRAFANA_API_URL + '/api/dashboards/uid/' + params
+        url = Settings.GRAFANA_API_URL.rstrip('/') + \
+            '/api/dashboards/uid/' + params
         response = grafana.url_validation(method, url)
         return response