]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson/osd: bail out if local version with requestor's when recovery
authorKefu Chai <kchai@redhat.com>
Sun, 20 Dec 2020 16:21:54 +0000 (00:21 +0800)
committerKefu Chai <kchai@redhat.com>
Sun, 20 Dec 2020 16:47:32 +0000 (00:47 +0800)
this is a todo.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/crimson/osd/replicated_recovery_backend.cc

index c68661fffed28cd4c02ea3da04ea3cf59d6b15cf..98619f03673860220e1a86fcd933b871b331a534 100644 (file)
@@ -365,6 +365,10 @@ seastar::future<PushOp> ReplicatedRecoveryBackend::build_push_op(
       // If requestor didn't know the version, use ours
       if (v == eversion_t()) {
         v = local_ver;
+      } else if (v != local_ver) {
+        logger().error("build_push_op: {} push {} v{} failed because local copy is {}",
+                       pg.get_pgid(), recovery_info.soid, recovery_info.version, local_ver);
+        // TODO: bail out
       }
       return read_omap_for_push_op(recovery_info.soid,
                                    progress,