]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rbd-mirror: snapshot create image state machine
authorJason Dillaman <dillaman@redhat.com>
Wed, 29 Jan 2020 02:25:19 +0000 (21:25 -0500)
committerJason Dillaman <dillaman@redhat.com>
Thu, 30 Jan 2020 15:26:36 +0000 (10:26 -0500)
Use the new mirror image creating state to track in-progress
snapshot-based mirroring image creations.

Signed-off-by: Jason Dillaman <dillaman@redhat.com>
src/test/rbd_mirror/CMakeLists.txt
src/test/rbd_mirror/image_replayer/snapshot/test_mock_CreateLocalImageRequest.cc [new file with mode: 0644]
src/tools/rbd_mirror/CMakeLists.txt
src/tools/rbd_mirror/image_replayer/snapshot/CreateLocalImageRequest.cc [new file with mode: 0644]
src/tools/rbd_mirror/image_replayer/snapshot/CreateLocalImageRequest.h [new file with mode: 0644]
src/tools/rbd_mirror/image_replayer/snapshot/StateBuilder.cc

index ddbb1bcf9afa72ccdbe250b74b7e3677f65879d5..dedabe8d3949d5b1b27375755a3c43c02ee19f8d 100644 (file)
@@ -42,6 +42,7 @@ add_executable(unittest_rbd_mirror
   image_replayer/journal/test_mock_PrepareReplayRequest.cc
   image_replayer/journal/test_mock_EventPreprocessor.cc
   image_replayer/journal/test_mock_Replayer.cc
+  image_replayer/snapshot/test_mock_CreateLocalImageRequest.cc
   image_sync/test_mock_SyncPointCreateRequest.cc
   image_sync/test_mock_SyncPointPruneRequest.cc
   pool_watcher/test_mock_RefreshImagesRequest.cc
diff --git a/src/test/rbd_mirror/image_replayer/snapshot/test_mock_CreateLocalImageRequest.cc b/src/test/rbd_mirror/image_replayer/snapshot/test_mock_CreateLocalImageRequest.cc
new file mode 100644 (file)
index 0000000..18304f6
--- /dev/null
@@ -0,0 +1,355 @@
+// -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*-
+// vim: ts=8 sw=2 smarttab
+
+#include "test/rbd_mirror/test_mock_fixture.h"
+#include "librbd/internal.h"
+#include "librbd/ImageState.h"
+#include "librbd/Operations.h"
+#include "tools/rbd_mirror/PoolMetaCache.h"
+#include "tools/rbd_mirror/Threads.h"
+#include "tools/rbd_mirror/image_replayer/CreateImageRequest.h"
+#include "tools/rbd_mirror/image_replayer/snapshot/CreateLocalImageRequest.h"
+#include "tools/rbd_mirror/image_replayer/snapshot/StateBuilder.h"
+#include "test/librados_test_stub/MockTestMemIoCtxImpl.h"
+#include "test/librbd/mock/MockImageCtx.h"
+#include "test/rbd_mirror/mock/MockContextWQ.h"
+#include "test/rbd_mirror/mock/MockSafeTimer.h"
+#include <boost/intrusive_ptr.hpp>
+
+namespace librbd {
+
+namespace {
+
+struct MockTestImageCtx : public librbd::MockImageCtx {
+  explicit MockTestImageCtx(librbd::ImageCtx &image_ctx)
+    : librbd::MockImageCtx(image_ctx) {
+  }
+};
+
+} // anonymous namespace
+
+namespace util {
+
+static std::string s_image_id;
+
+template <>
+std::string generate_image_id<MockTestImageCtx>(librados::IoCtx&) {
+  ceph_assert(!s_image_id.empty());
+  return s_image_id;
+}
+
+} // namespace util
+} // namespace librbd
+
+namespace rbd {
+namespace mirror {
+
+template <>
+struct Threads<librbd::MockTestImageCtx> {
+  ceph::mutex &timer_lock;
+  SafeTimer *timer;
+  ContextWQ *work_queue;
+
+  Threads(Threads<librbd::ImageCtx> *threads)
+    : timer_lock(threads->timer_lock), timer(threads->timer),
+      work_queue(threads->work_queue) {
+  }
+};
+
+namespace image_replayer {
+
+template<>
+struct CreateImageRequest<librbd::MockTestImageCtx> {
+  static CreateImageRequest* s_instance;
+  Context *on_finish = nullptr;
+
+  static CreateImageRequest* create(Threads<librbd::MockTestImageCtx>* threads,
+                                    librados::IoCtx &local_io_ctx,
+                                    const std::string &global_image_id,
+                                    const std::string &remote_mirror_uuid,
+                                    const std::string &local_image_name,
+                                   const std::string &local_image_id,
+                                    librbd::MockTestImageCtx *remote_image_ctx,
+                                    PoolMetaCache* pool_meta_cache,
+                                    cls::rbd::MirrorImageMode mirror_image_mode,
+                                    Context *on_finish) {
+    ceph_assert(s_instance != nullptr);
+    s_instance->on_finish = on_finish;
+    s_instance->construct(local_image_id);
+    return s_instance;
+  }
+
+  CreateImageRequest() {
+    ceph_assert(s_instance == nullptr);
+    s_instance = this;
+  }
+  ~CreateImageRequest() {
+    s_instance = nullptr;
+  }
+
+  MOCK_METHOD1(construct, void(const std::string&));
+  MOCK_METHOD0(send, void());
+};
+
+CreateImageRequest<librbd::MockTestImageCtx>*
+  CreateImageRequest<librbd::MockTestImageCtx>::s_instance = nullptr;
+
+namespace snapshot {
+
+template<>
+struct StateBuilder<librbd::MockTestImageCtx> {
+  std::string local_image_id;
+  std::string remote_mirror_uuid;
+};
+
+} // namespace snapshot
+} // namespace image_replayer
+} // namespace mirror
+} // namespace rbd
+
+#include "tools/rbd_mirror/image_replayer/snapshot/CreateLocalImageRequest.cc"
+
+using ::testing::_;
+using ::testing::InSequence;
+using ::testing::Invoke;
+using ::testing::Return;
+using ::testing::StrEq;
+
+namespace rbd {
+namespace mirror {
+namespace image_replayer {
+namespace snapshot {
+
+class TestMockImageReplayerSnapshotCreateLocalImageRequest : public TestMockFixture {
+public:
+  typedef CreateLocalImageRequest<librbd::MockTestImageCtx> MockCreateLocalImageRequest;
+  typedef Threads<librbd::MockTestImageCtx> MockThreads;
+  typedef CreateImageRequest<librbd::MockTestImageCtx> MockCreateImageRequest;
+  typedef StateBuilder<librbd::MockTestImageCtx> MockStateBuilder;
+
+  void SetUp() override {
+    TestMockFixture::SetUp();
+
+    librbd::RBD rbd;
+    ASSERT_EQ(0, create_image(rbd, m_remote_io_ctx, m_image_name, m_image_size));
+    ASSERT_EQ(0, open_image(m_remote_io_ctx, m_image_name, &m_remote_image_ctx));
+    m_mock_remote_image_ctx = new librbd::MockTestImageCtx(*m_remote_image_ctx);
+  }
+
+  void TearDown() override {
+    delete m_mock_remote_image_ctx;
+    TestMockFixture::TearDown();
+  }
+
+  void snap_create(librbd::ImageCtx *image_ctx, const std::string &snap_name) {
+    ASSERT_EQ(0, image_ctx->operations->snap_create(cls::rbd::UserSnapshotNamespace(),
+                                                   snap_name.c_str()));
+    ASSERT_EQ(0, image_ctx->operations->snap_protect(cls::rbd::UserSnapshotNamespace(),
+                                                    snap_name.c_str()));
+    ASSERT_EQ(0, image_ctx->state->refresh());
+  }
+
+  int clone_image(librbd::ImageCtx *parent_image_ctx,
+                  const std::string &snap_name, const std::string &clone_name) {
+    snap_create(parent_image_ctx, snap_name);
+
+    int order = 0;
+    return librbd::clone(m_remote_io_ctx, parent_image_ctx->name.c_str(),
+                         snap_name.c_str(), m_remote_io_ctx,
+                         clone_name.c_str(), parent_image_ctx->features,
+                         &order, 0, 0);
+  }
+
+  void expect_mirror_image_set(const std::string& image_id,
+                               const cls::rbd::MirrorImage& mirror_image,
+                               int r) {
+    bufferlist bl;
+    encode(image_id, bl);
+    encode(mirror_image, bl);
+
+    EXPECT_CALL(get_mock_io_ctx(m_local_io_ctx),
+                exec(RBD_MIRRORING, _, StrEq("rbd"),
+                     StrEq("mirror_image_set"), ContentsEqual(bl), _, _))
+      .WillOnce(Return(r));
+  }
+
+  void expect_mirror_image_remove(const std::string& image_id, int r) {
+    bufferlist bl;
+    encode(image_id, bl);
+
+    EXPECT_CALL(get_mock_io_ctx(m_local_io_ctx),
+                exec(StrEq("rbd_mirroring"), _, StrEq("rbd"),
+                     StrEq("mirror_image_remove"),
+                     ContentsEqual(bl), _, _))
+      .WillOnce(Return(r));
+  }
+
+  void expect_create_image(MockCreateImageRequest& mock_create_image_request,
+                           const std::string& image_id, int r) {
+    EXPECT_CALL(mock_create_image_request, construct(image_id));
+    EXPECT_CALL(mock_create_image_request, send())
+      .WillOnce(Invoke([this, &mock_create_image_request, r]() {
+          m_threads->work_queue->queue(mock_create_image_request.on_finish, r);
+        }));
+  }
+
+  MockCreateLocalImageRequest* create_request(
+      MockThreads& mock_threads,
+      MockStateBuilder& mock_state_builder,
+      const std::string& global_image_id,
+      Context* on_finish) {
+    return new MockCreateLocalImageRequest(
+      &mock_threads, m_local_io_ctx, m_mock_remote_image_ctx,
+      global_image_id, &m_pool_meta_cache, nullptr, &mock_state_builder,
+      on_finish);
+  }
+
+  PoolMetaCache m_pool_meta_cache{g_ceph_context};
+
+  librbd::ImageCtx *m_remote_image_ctx;
+  librbd::MockTestImageCtx *m_mock_remote_image_ctx = nullptr;
+};
+
+TEST_F(TestMockImageReplayerSnapshotCreateLocalImageRequest, Success) {
+  InSequence seq;
+
+  librbd::util::s_image_id = "local image id";
+  expect_mirror_image_set("local image id",
+                          {cls::rbd::MIRROR_IMAGE_MODE_SNAPSHOT,
+                           "global image id",
+                           cls::rbd::MIRROR_IMAGE_STATE_CREATING}, 0);
+
+  MockCreateImageRequest mock_create_image_request;
+  expect_create_image(mock_create_image_request, "local image id", 0);
+
+  C_SaferCond ctx;
+  MockThreads mock_threads(m_threads);
+  MockStateBuilder mock_state_builder;
+  auto request = create_request(
+    mock_threads, mock_state_builder, "global image id", &ctx);
+  request->send();
+  ASSERT_EQ(0, ctx.wait());
+
+  ASSERT_EQ("local image id", mock_state_builder.local_image_id);
+}
+
+TEST_F(TestMockImageReplayerSnapshotCreateLocalImageRequest, AddMirrorImageError) {
+  InSequence seq;
+
+  librbd::util::s_image_id = "local image id";
+  expect_mirror_image_set("local image id",
+                          {cls::rbd::MIRROR_IMAGE_MODE_SNAPSHOT,
+                           "global image id",
+                           cls::rbd::MIRROR_IMAGE_STATE_CREATING}, -EINVAL);
+
+  C_SaferCond ctx;
+  MockThreads mock_threads(m_threads);
+  MockStateBuilder mock_state_builder;
+  auto request = create_request(
+    mock_threads, mock_state_builder, "global image id", &ctx);
+  request->send();
+  ASSERT_EQ(-EINVAL, ctx.wait());
+}
+
+TEST_F(TestMockImageReplayerSnapshotCreateLocalImageRequest, CreateImageError) {
+  InSequence seq;
+
+  librbd::util::s_image_id = "local image id";
+  expect_mirror_image_set("local image id",
+                          {cls::rbd::MIRROR_IMAGE_MODE_SNAPSHOT,
+                           "global image id",
+                           cls::rbd::MIRROR_IMAGE_STATE_CREATING}, 0);
+
+  MockCreateImageRequest mock_create_image_request;
+  expect_create_image(mock_create_image_request, "local image id", -EINVAL);
+
+  C_SaferCond ctx;
+  MockThreads mock_threads(m_threads);
+  MockStateBuilder mock_state_builder;
+  auto request = create_request(
+    mock_threads, mock_state_builder, "global image id", &ctx);
+  request->send();
+  ASSERT_EQ(-EINVAL, ctx.wait());
+}
+
+TEST_F(TestMockImageReplayerSnapshotCreateLocalImageRequest, CreateImageDuplicate) {
+  InSequence seq;
+
+  librbd::util::s_image_id = "local image id";
+  expect_mirror_image_set("local image id",
+                          {cls::rbd::MIRROR_IMAGE_MODE_SNAPSHOT,
+                           "global image id",
+                           cls::rbd::MIRROR_IMAGE_STATE_CREATING}, 0);
+
+  MockCreateImageRequest mock_create_image_request;
+  expect_create_image(mock_create_image_request, "local image id", -EBADF);
+
+  expect_mirror_image_set("local image id",
+                          {cls::rbd::MIRROR_IMAGE_MODE_SNAPSHOT,
+                           "global image id",
+                           cls::rbd::MIRROR_IMAGE_STATE_DISABLING}, 0);
+
+  expect_mirror_image_remove("local image id", 0);
+
+  expect_mirror_image_set("local image id",
+                          {cls::rbd::MIRROR_IMAGE_MODE_SNAPSHOT,
+                           "global image id",
+                           cls::rbd::MIRROR_IMAGE_STATE_CREATING}, 0);
+
+  expect_create_image(mock_create_image_request, "local image id", 0);
+
+  C_SaferCond ctx;
+  MockThreads mock_threads(m_threads);
+  MockStateBuilder mock_state_builder;
+  auto request = create_request(
+    mock_threads, mock_state_builder, "global image id", &ctx);
+  request->send();
+  ASSERT_EQ(0, ctx.wait());
+
+  ASSERT_EQ("local image id", mock_state_builder.local_image_id);
+}
+
+TEST_F(TestMockImageReplayerSnapshotCreateLocalImageRequest, DisableMirrorImageError) {
+  InSequence seq;
+
+  librbd::util::s_image_id = "local image id";
+  expect_mirror_image_set("local image id",
+                          {cls::rbd::MIRROR_IMAGE_MODE_SNAPSHOT,
+                           "global image id",
+                           cls::rbd::MIRROR_IMAGE_STATE_DISABLING}, -EINVAL);
+
+  C_SaferCond ctx;
+  MockThreads mock_threads(m_threads);
+  MockStateBuilder mock_state_builder;
+  mock_state_builder.local_image_id = "local image id";
+  auto request = create_request(
+    mock_threads, mock_state_builder, "global image id", &ctx);
+  request->send();
+  ASSERT_EQ(-EINVAL, ctx.wait());
+}
+
+TEST_F(TestMockImageReplayerSnapshotCreateLocalImageRequest, RemoveMirrorImageError) {
+  InSequence seq;
+
+  librbd::util::s_image_id = "local image id";
+  expect_mirror_image_set("local image id",
+                          {cls::rbd::MIRROR_IMAGE_MODE_SNAPSHOT,
+                           "global image id",
+                           cls::rbd::MIRROR_IMAGE_STATE_DISABLING}, 0);
+
+  expect_mirror_image_remove("local image id", -EINVAL);
+
+  C_SaferCond ctx;
+  MockThreads mock_threads(m_threads);
+  MockStateBuilder mock_state_builder;
+  mock_state_builder.local_image_id = "local image id";
+  auto request = create_request(
+    mock_threads, mock_state_builder, "global image id", &ctx);
+  request->send();
+  ASSERT_EQ(-EINVAL, ctx.wait());
+}
+
+} // namespace journal
+} // namespace image_replayer
+} // namespace mirror
+} // namespace rbd
index 8d0007077f22ddf8c2ba07dbe120a76f96a9cb93..92aa4662496924a260f228431a3f34ba11101166 100644 (file)
@@ -51,6 +51,7 @@ set(rbd_mirror_internal
   image_replayer/journal/ReplayStatusFormatter.cc
   image_replayer/journal/StateBuilder.cc
   image_replayer/journal/SyncPointHandler.cc
+  image_replayer/snapshot/CreateLocalImageRequest.cc
   image_replayer/snapshot/StateBuilder.cc
   image_sync/SyncPointCreateRequest.cc
   image_sync/SyncPointPruneRequest.cc
diff --git a/src/tools/rbd_mirror/image_replayer/snapshot/CreateLocalImageRequest.cc b/src/tools/rbd_mirror/image_replayer/snapshot/CreateLocalImageRequest.cc
new file mode 100644 (file)
index 0000000..c923395
--- /dev/null
@@ -0,0 +1,204 @@
+// -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*-
+// vim: ts=8 sw=2 smarttab
+
+#include "CreateLocalImageRequest.h"
+#include "include/rados/librados.hpp"
+#include "common/debug.h"
+#include "common/dout.h"
+#include "common/errno.h"
+#include "cls/rbd/cls_rbd_client.h"
+#include "cls/rbd/cls_rbd_types.h"
+#include "librbd/ImageCtx.h"
+#include "librbd/Utils.h"
+#include "tools/rbd_mirror/ProgressContext.h"
+#include "tools/rbd_mirror/image_replayer/CreateImageRequest.h"
+#include "tools/rbd_mirror/image_replayer/snapshot/StateBuilder.h"
+
+#define dout_context g_ceph_context
+#define dout_subsys ceph_subsys_rbd_mirror
+#undef dout_prefix
+#define dout_prefix *_dout << "rbd::mirror::image_replayer::snapshot::" \
+                           << "CreateLocalImageRequest: " << this << " " \
+                           << __func__ << ": "
+
+namespace rbd {
+namespace mirror {
+namespace image_replayer {
+namespace snapshot {
+
+using librbd::util::create_context_callback;
+using librbd::util::create_rados_callback;
+
+template <typename I>
+void CreateLocalImageRequest<I>::send() {
+  disable_mirror_image();
+}
+
+template <typename I>
+void CreateLocalImageRequest<I>::disable_mirror_image() {
+  if (m_state_builder->local_image_id.empty()) {
+    add_mirror_image();
+    return;
+  }
+
+  dout(10) << dendl;
+  update_progress("DISABLE_MIRROR_IMAGE");
+
+  // need to send 'disabling' since the cls methods will fail if we aren't
+  // in that state
+  cls::rbd::MirrorImage mirror_image{
+    cls::rbd::MIRROR_IMAGE_MODE_SNAPSHOT, m_global_image_id,
+    cls::rbd::MIRROR_IMAGE_STATE_DISABLING};
+  librados::ObjectWriteOperation op;
+  librbd::cls_client::mirror_image_set(&op, m_state_builder->local_image_id,
+                                       mirror_image);
+
+  auto aio_comp = create_rados_callback<
+    CreateLocalImageRequest<I>,
+    &CreateLocalImageRequest<I>::handle_disable_mirror_image>(this);
+  int r = m_local_io_ctx.aio_operate(RBD_MIRRORING, aio_comp, &op);
+  ceph_assert(r == 0);
+  aio_comp->release();
+}
+
+template <typename I>
+void CreateLocalImageRequest<I>::handle_disable_mirror_image(int r) {
+  dout(10) << "r=" << r << dendl;
+
+  if (r < 0) {
+    derr << "failed to disable mirror image " << m_global_image_id << ": "
+         << cpp_strerror(r) << dendl;
+    finish(r);
+    return;
+  }
+
+  remove_mirror_image();
+}
+
+template <typename I>
+void CreateLocalImageRequest<I>::remove_mirror_image() {
+  dout(10) << dendl;
+  update_progress("REMOVE_MIRROR_IMAGE");
+
+  librados::ObjectWriteOperation op;
+  librbd::cls_client::mirror_image_remove(&op, m_state_builder->local_image_id);
+
+  auto aio_comp = create_rados_callback<
+    CreateLocalImageRequest<I>,
+    &CreateLocalImageRequest<I>::handle_remove_mirror_image>(this);
+  int r = m_local_io_ctx.aio_operate(RBD_MIRRORING, aio_comp, &op);
+  ceph_assert(r == 0);
+  aio_comp->release();
+}
+
+template <typename I>
+void CreateLocalImageRequest<I>::handle_remove_mirror_image(int r) {
+  dout(10) << "r=" << r << dendl;
+
+  if (r < 0) {
+    derr << "failed to remove mirror image " << m_global_image_id << ": "
+         << cpp_strerror(r) << dendl;
+    finish(r);
+    return;
+  }
+
+  m_state_builder->local_image_id = "";
+  add_mirror_image();
+}
+
+template <typename I>
+void CreateLocalImageRequest<I>::add_mirror_image() {
+  ceph_assert(m_state_builder->local_image_id.empty());
+  m_state_builder->local_image_id =
+    librbd::util::generate_image_id<I>(m_local_io_ctx);
+
+  dout(10) << "local_image_id=" << m_state_builder->local_image_id << dendl;
+  update_progress("ADD_MIRROR_IMAGE");
+
+  // use 'creating' to track a partially constructed image. it will
+  // be switched to 'enabled' once the image is fully created
+  cls::rbd::MirrorImage mirror_image{
+    cls::rbd::MIRROR_IMAGE_MODE_SNAPSHOT, m_global_image_id,
+    cls::rbd::MIRROR_IMAGE_STATE_CREATING};
+  librados::ObjectWriteOperation op;
+  librbd::cls_client::mirror_image_set(&op, m_state_builder->local_image_id,
+                                       mirror_image);
+
+  auto aio_comp = create_rados_callback<
+    CreateLocalImageRequest<I>,
+    &CreateLocalImageRequest<I>::handle_add_mirror_image>(this);
+  int r = m_local_io_ctx.aio_operate(RBD_MIRRORING, aio_comp, &op);
+  ceph_assert(r == 0);
+  aio_comp->release();
+}
+
+template <typename I>
+void CreateLocalImageRequest<I>::handle_add_mirror_image(int r) {
+  dout(10) << "r=" << r << dendl;
+
+  if (r < 0) {
+    derr << "failed to register mirror image " << m_global_image_id << ": "
+         << cpp_strerror(r) << dendl;
+    this->finish(r);
+    return;
+  }
+
+  create_local_image();
+}
+
+template <typename I>
+void CreateLocalImageRequest<I>::create_local_image() {
+  dout(10) << "local_image_id=" << m_state_builder->local_image_id << dendl;
+  update_progress("CREATE_LOCAL_IMAGE");
+
+  m_remote_image_ctx->image_lock.lock_shared();
+  std::string image_name = m_remote_image_ctx->name;
+  m_remote_image_ctx->image_lock.unlock_shared();
+
+  auto ctx = create_context_callback<
+    CreateLocalImageRequest<I>,
+    &CreateLocalImageRequest<I>::handle_create_local_image>(this);
+  auto request = CreateImageRequest<I>::create(
+    m_threads, m_local_io_ctx, m_global_image_id,
+    m_state_builder->remote_mirror_uuid, image_name,
+    m_state_builder->local_image_id, m_remote_image_ctx,
+    m_pool_meta_cache, cls::rbd::MIRROR_IMAGE_MODE_SNAPSHOT, ctx);
+  request->send();
+}
+template <typename I>
+void CreateLocalImageRequest<I>::handle_create_local_image(int r) {
+  dout(10) << "r=" << r << dendl;
+
+  if (r == -EBADF) {
+    dout(5) << "image id " << m_state_builder->local_image_id << " "
+            << "already in-use" << dendl;
+    disable_mirror_image();
+    return;
+  } else if (r < 0) {
+    if (r == -ENOENT) {
+      dout(10) << "parent image does not exist" << dendl;
+    } else {
+      derr << "failed to create local image: " << cpp_strerror(r) << dendl;
+    }
+    finish(r);
+    return;
+  }
+
+  finish(0);
+}
+
+template <typename I>
+void CreateLocalImageRequest<I>::update_progress(
+    const std::string& description) {
+  dout(15) << description << dendl;
+  if (m_progress_ctx != nullptr) {
+    m_progress_ctx->update_progress(description);
+  }
+}
+
+} // namespace snapshot
+} // namespace image_replayer
+} // namespace mirror
+} // namespace rbd
+
+template class rbd::mirror::image_replayer::snapshot::CreateLocalImageRequest<librbd::ImageCtx>;
diff --git a/src/tools/rbd_mirror/image_replayer/snapshot/CreateLocalImageRequest.h b/src/tools/rbd_mirror/image_replayer/snapshot/CreateLocalImageRequest.h
new file mode 100644 (file)
index 0000000..3345154
--- /dev/null
@@ -0,0 +1,121 @@
+// -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*-
+// vim: ts=8 sw=2 smarttab
+
+#ifndef RBD_MIRROR_IMAGE_REPLAYER_SNAPSHOT_CREATE_LOCAL_IMAGE_REQUEST_H
+#define RBD_MIRROR_IMAGE_REPLAYER_SNAPSHOT_CREATE_LOCAL_IMAGE_REQUEST_H
+
+#include "include/rados/librados_fwd.hpp"
+#include "tools/rbd_mirror/BaseRequest.h"
+#include <string>
+
+struct Context;
+namespace librbd { class ImageCtx; }
+
+namespace rbd {
+namespace mirror {
+
+class PoolMetaCache;
+class ProgressContext;
+template <typename> struct Threads;
+
+namespace image_replayer {
+namespace snapshot {
+
+template <typename> class StateBuilder;
+
+template <typename ImageCtxT>
+class CreateLocalImageRequest : public BaseRequest {
+public:
+  typedef rbd::mirror::ProgressContext ProgressContext;
+
+  static CreateLocalImageRequest* create(
+      Threads<ImageCtxT>* threads,
+      librados::IoCtx& local_io_ctx,
+      ImageCtxT* remote_image_ctx,
+      const std::string& global_image_id,
+      PoolMetaCache* pool_meta_cache,
+      ProgressContext* progress_ctx,
+      StateBuilder<ImageCtxT>* state_builder,
+      Context* on_finish) {
+    return new CreateLocalImageRequest(threads, local_io_ctx, remote_image_ctx,
+                                       global_image_id, pool_meta_cache,
+                                       progress_ctx, state_builder, on_finish);
+  }
+
+  CreateLocalImageRequest(
+      Threads<ImageCtxT>* threads,
+      librados::IoCtx& local_io_ctx,
+      ImageCtxT* remote_image_ctx,
+      const std::string& global_image_id,
+      PoolMetaCache* pool_meta_cache,
+      ProgressContext* progress_ctx,
+      StateBuilder<ImageCtxT>* state_builder,
+      Context* on_finish)
+    : BaseRequest(on_finish),
+      m_threads(threads),
+      m_local_io_ctx(local_io_ctx),
+      m_remote_image_ctx(remote_image_ctx),
+      m_global_image_id(global_image_id),
+      m_pool_meta_cache(pool_meta_cache),
+      m_progress_ctx(progress_ctx),
+      m_state_builder(state_builder) {
+  }
+
+  void send();
+
+private:
+  /**
+   * @verbatim
+   *
+   * <start>
+   *    |
+   *    v
+   * DISABLE_MIRROR_IMAGE < * * * * * *
+   *    |                             *
+   *    v                             *
+   * REMOVE_MIRROR_IMAGE              *
+   *    |                             *
+   *    v                             *
+   * ADD_MIRROR_IMAGE                 *
+   *    |                             *
+   *    v               (id exists)   *
+   * CREATE_LOCAL_IMAGE * * * * * * * *
+   *    |
+   *    v
+   * <finish>
+   *
+   * @endverbatim
+   */
+
+  Threads<ImageCtxT>* m_threads;
+  librados::IoCtx& m_local_io_ctx;
+  ImageCtxT* m_remote_image_ctx;
+  std::string m_global_image_id;
+  PoolMetaCache* m_pool_meta_cache;
+  ProgressContext* m_progress_ctx;
+  StateBuilder<ImageCtxT>* m_state_builder;
+
+  void disable_mirror_image();
+  void handle_disable_mirror_image(int r);
+
+  void remove_mirror_image();
+  void handle_remove_mirror_image(int r);
+
+  void add_mirror_image();
+  void handle_add_mirror_image(int r);
+
+  void create_local_image();
+  void handle_create_local_image(int r);
+
+  void update_progress(const std::string& description);
+
+};
+
+} // namespace snapshot
+} // namespace image_replayer
+} // namespace mirror
+} // namespace rbd
+
+extern template class rbd::mirror::image_replayer::snapshot::CreateLocalImageRequest<librbd::ImageCtx>;
+
+#endif // RBD_MIRROR_IMAGE_REPLAYER_SNAPSHOT_CREATE_LOCAL_IMAGE_REQUEST_H
index 648e38d2f6e7184a890f966852322681502f35e9..fcaa3c17b268a754e6b43bbd743363a9b79a5171 100644 (file)
@@ -7,6 +7,7 @@
 #include "common/debug.h"
 #include "common/errno.h"
 #include "librbd/ImageCtx.h"
+#include "tools/rbd_mirror/image_replayer/snapshot/CreateLocalImageRequest.h"
 
 #define dout_context g_ceph_context
 #define dout_subsys ceph_subsys_rbd_mirror
@@ -70,9 +71,9 @@ BaseRequest* StateBuilder<I>::create_local_image_request(
     PoolMetaCache* pool_meta_cache,
     ProgressContext* progress_ctx,
     Context* on_finish) {
-  // TODO
-  ceph_assert(false);
-  return nullptr;
+  return CreateLocalImageRequest<I>::create(
+    threads, local_io_ctx, this->remote_image_ctx, global_image_id,
+    pool_meta_cache, progress_ctx, this, on_finish);
 }
 
 template <typename I>