os/GenericObjectMap.cc: pass big parameter by reference

CID 1188142 (#1 of 1): Big parameter passed by value (PASS_BY_VALUE)
 pass_by_value: Passing parameter header of type
 GenericObjectMap::_Header (size 176 bytes) by value.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>

diff --git a/src/os/GenericObjectMap.cc b/src/os/GenericObjectMap.cc
index 00387ad666d6d66a837e5079ff672adf12800841..f6ba11eaf14660adeea478bca27b4f1afda94de3 100644 (file)
--- a/src/os/GenericObjectMap.cc
+++ b/src/os/GenericObjectMap.cc
@@ -1025,7 +1025,7 @@ void GenericObjectMap::remove_header(const coll_t &cid,
 }
 
 void GenericObjectMap::set_header(const coll_t &cid, const ghobject_t &oid,
-                                  _Header header, KeyValueDB::Transaction t)
+                                  _Header &header, KeyValueDB::Transaction t)
 {
   dout(20) << __func__ << " setting " << header.seq
            << " cid " << cid << " oid " << oid << " parent seq "

diff --git a/src/os/GenericObjectMap.h b/src/os/GenericObjectMap.h
index 4a0c99c94b911ce052dc60eaae0871f9ec6976d6..b254795207398aa2155d0dc85376293369b9fcce 100644 (file)
--- a/src/os/GenericObjectMap.h
+++ b/src/os/GenericObjectMap.h
@@ -220,7 +220,7 @@ class GenericObjectMap {
     KeyValueDB::Transaction t);
 
   /// Set leaf node for c and oid to the value of header
-  void set_header(const coll_t &cid, const ghobject_t &oid, _Header header,
+  void set_header(const coll_t &cid, const ghobject_t &oid, _Header &header,
     KeyValueDB::Transaction t);
 
   // Move all modify member function to "protect", in order to indicate these